Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook custom renderers are not very discoverable if multiple exist #148724

Closed
pwang347 opened this issue May 4, 2022 · 1 comment · Fixed by #152670
Closed

Notebook custom renderers are not very discoverable if multiple exist #148724

pwang347 opened this issue May 4, 2022 · 1 comment · Fixed by #152670
Assignees
Labels
insiders-released Patch has been released in VS Code Insiders notebook-output under-discussion Issue is under discussion for relevance, priority, approach verification-needed Verification of issue is requested
Milestone

Comments

@pwang347
Copy link
Member

pwang347 commented May 4, 2022

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.67.0-insider
  • OS Version: Windows 10

Steps to Reproduce:

  1. Author a new VS Code Notebook Renderer using the official guide
  2. According to the description here, it should be possible to override MIME types with built-in renderers, e.g.:

An extension may optionally choose to render "simple" Rich Outputs itself, for instance to add LaTeX support to Markdown outputs.

  1. I tried to create a renderer replacing the text/html renderer, but didn't realize it was buried under the following UI interface:
    image
    image

For the output renderer I am authoring, I am mainly looking to augment the existing HTML renderer (ie. add a button above the existing output) so it wouldn't make sense to have users manually select it as a renderer option. Would it be possible to either make the renderer more discoverable or add some API to allow for the scenario I'm describing where it's mostly an augmentation and therefore should be shown by default?

Thanks!

@rebornix rebornix self-assigned this May 4, 2022
@rebornix rebornix added under-discussion Issue is under discussion for relevance, priority, approach notebook-output labels May 4, 2022
@rebornix rebornix added this to the May 2022 milestone May 19, 2022
@rebornix rebornix modified the milestones: May 2022, June 2022 Jun 1, 2022
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 20, 2022
@rebornix rebornix added the verification-needed Verification of issue is requested label Jun 28, 2022
@rebornix
Copy link
Member

Verifier: when following https://code.visualstudio.com/api/extension-guides/notebook#notebook-renderer to create a renderer extension, type in text/html for the mimetype.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
insiders-released Patch has been released in VS Code Insiders notebook-output under-discussion Issue is under discussion for relevance, priority, approach verification-needed Verification of issue is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants
@rebornix @connor4312 @pwang347 @greazer @VSCodeTriageBot and others