Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings Sync picks up theme change #145803

Closed
TylerLeonhardt-alt opened this issue Mar 22, 2022 · 2 comments
Closed

Settings Sync picks up theme change #145803

TylerLeonhardt-alt opened this issue Mar 22, 2022 · 2 comments
Assignees

Comments

@TylerLeonhardt-alt
Copy link

TylerLeonhardt-alt commented Mar 22, 2022

Testing #145616

image

Since you are automatically changing the theme color based on the OS, I don't think this theme change should be synced... otherwise, when I move to another machine where I don't use high contrast, my theme will be overwritten and the high contrast theme will be used and that will be jarring.

This is @TylerLeonhardt's alt account for linux testing

@TylerLeonhardt
Copy link
Member

A symptom of this ... a few times for me this caused Settings Sync merge conflicts when I opened VS Code after switching on high contrast.

@aeschli
Copy link
Contributor

aeschli commented Mar 23, 2022

Duplicate of #124572

@aeschli aeschli marked this as a duplicate of #124572 Mar 23, 2022
@aeschli aeschli closed this as completed Mar 23, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants