Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ARM build image for ripgrep #145541

Closed
navehgrofi opened this issue Mar 21, 2022 · 9 comments
Closed

Change ARM build image for ripgrep #145541

navehgrofi opened this issue Mar 21, 2022 · 9 comments
Assignees
Labels
debt Code quality issues engineering VS Code - Build / issue tracking / etc. linux Issues with VS Code on Linux search Search widget and operation issues ssh
Milestone

Comments

@navehgrofi
Copy link

VSCode version - 1.65.2, Windows x64.

Im controlling RPI via Remote-SSH for over a year now.
on latest version, global search is not working on remote machine anymore.
when opening a local folder, global search works great.
when opening remote folder, global search is only working on open files and only if you have viewed this file 1 time at least!

what i tried:

  1. not use ignore files
  2. remove all ignore patterns
  3. delete user JSON settings file
  4. verify that the "search only in open editors" button is not selected

im not sure what else to try

@roblourens
Copy link
Member

Please do the following

  • Run the command "Set log level" and change it to "Trace"
  • Run the search again
  • Show the search-related messages in the "Log (Window)" and "Log (Extension Host)" output panel

image

@roblourens roblourens added the info-needed Issue requires more information from poster label Mar 21, 2022
@navehgrofi
Copy link
Author

navehgrofi commented Mar 22, 2022

Please do the following

  • Run the command "Set log level" and change it to "Trace"
  • Run the search again
  • Show the search-related messages in the "Log (Window)" and "Log (Extension Host)" output panel

image

@roblourens ,

thanks, here is the Log(Window) trace:

https://pastebin.com/wJ0SpUrF

===============================
Log (Extension Host) output show no log from this action, but Log (Remote Extension Host) does show and here it is:

https://pastebin.com/AGgugcDf

@roblourens
Copy link
Member

I guess this is the problem

[2022-03-22 12:35:46.467] [exthost] [debug] RipgrepSearchEH#search /home/pi/.vscode-server/bin/c722ca6c7eed3d7987c0d5c3df5c45f6b15e77d1/node_modules/@vscode/ripgrep/bin/rg: /lib/arm-linux-gnueabihf/libc.so.6: version `GLIBC_2.28' not found (required by /home/pi/.vscode-server/bin/c722ca6c7eed3d7987c0d5c3df5c45f6b15e77d1/node_modules/@vscode/ripgrep/bin/rg)

If this used to work, I guess it would be from microsoft/ripgrep-prebuilt@f764a98

@deepak1556 do we have a certain GLIBC requirement for vscode? Should I build ripgrep in the same image we use for vscode?

@deepak1556
Copy link
Collaborator

deepak1556 commented Mar 23, 2022

I haven't addressed this for our arm server builds yet but we will target glibc >= 2.24 based on this table https://github.com/nodejs/node/blob/master/BUILDING.md#platform-list.

Should I build ripgrep in the same image we use for vscode?

Yup that sounds good and in your case it only needs to be done for the arm flavors of ripgrep which rely on the gnu C library, intel flavors are built using musl so they should be fine.

I can share the image details once I address microsoft/vscode-remote-release#2998

@deepak1556 deepak1556 reopened this Mar 31, 2022
@deepak1556 deepak1556 removed the info-needed Issue requires more information from poster label Mar 31, 2022
@deepak1556 deepak1556 self-assigned this Mar 31, 2022
@deepak1556 deepak1556 added this to the April 2022 milestone Mar 31, 2022
@deepak1556 deepak1556 added search Search widget and operation issues linux Issues with VS Code on Linux engineering VS Code - Build / issue tracking / etc. ssh labels Mar 31, 2022
@roblourens roblourens changed the title Global Search doesnt work on Remote SSH Change ARM build image for ripgrep Apr 22, 2022
@roblourens roblourens modified the milestones: April 2022, May 2022 Apr 22, 2022
@roblourens roblourens modified the milestones: May 2022, June 2022 Jun 1, 2022
@roblourens roblourens modified the milestones: June 2022, July 2022 Jun 29, 2022
@roblourens roblourens modified the milestones: July 2022, August 2022 Jul 20, 2022
@deepak1556
Copy link
Collaborator

Sorry forgot to update here, our arm64 server uses the following image to build https://github.com/microsoft/vscode-linux-build-agent/blob/main/centos7-devtoolset8-arm64/Dockerfile which provides support for glibc >= 2.17

armhf server uses https://github.com/microsoft/vscode-linux-build-agent/blob/main/stretch-armhf/Dockerfile which supports glibc >= 2.24

@deepak1556 deepak1556 modified the milestones: August 2022, Backlog Aug 23, 2022
@navehgrofiSYNA
Copy link

@roblourens @deepak1556

is there any plan to solve it?

@roblourens roblourens added the debt Code quality issues label Dec 6, 2022
@andreamah andreamah assigned andreamah and unassigned roblourens Dec 15, 2022
@roblourens
Copy link
Member

Example of an issue that will be addressed: microsoft/vscode-remote-release#6930

We technically support glibc 2.17 in vscode, but ripgrep is not built for it

@roblourens
Copy link
Member

We are building a statically-linked version of ripgrep now, this should be resolved.

@github-actions github-actions bot locked and limited conversation to collaborators May 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues engineering VS Code - Build / issue tracking / etc. linux Issues with VS Code on Linux search Search widget and operation issues ssh
Projects
None yet
Development

No branches or pull requests

6 participants
@roblourens @deepak1556 @navehgrofi @andreamah @navehgrofiSYNA and others