Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Enhanced TAR downloading #143575

Closed
2 tasks done
JacksonKearl opened this issue Feb 21, 2022 · 3 comments
Closed
2 tasks done

Test: Enhanced TAR downloading #143575

JacksonKearl opened this issue Feb 21, 2022 · 3 comments

Comments

@JacksonKearl
Copy link
Contributor

JacksonKearl commented Feb 21, 2022

Refs: microsoft/vscode-anycode#9

  • anyOS @chrmarti (web, insiders.vscode.dev)
  • anyOS @rchiodo (desktop RemoteHub Insiders)

Complexity: 4

Create Issue


Ensure you are on latest build with remoteHub.indexing.maxIndexSize: 50 by default.

The latest RemoteHub now downloads tar files much more aggressively. By default they will be downloaded on request from either workspace search or AnyCode's indexing, with the only exception being that the request is by default cancelled after 50MB.

Test on a variety of repo sizes (I used microsoft/vscode, microsoft/typescript, and torvalds/linux) and network throttles:

  • Search gives good results and respects flags/etc. by default
  • AnyCode doesn't make a ton of network requests (check devtools, requests for tree's are expected, but not requests for file contents)
  • The notification about downloading the TAR has a good progress indication and supports cancellation.
    • Upon cancelling the request, the code should fall back to API-powered utils, for example search should gracefully fall back to GitHub API powered search when you cancel without needing further interaction.
    • The search view should also notify you of the cancellation and give a link to retry downloading the index
    • Once you cancel index downloading for a repo, it doesn't attempt to download the index again until you manually opt back in
  • remoteHub.indexing.maxIndexSize, configures the limit for downloading, try setting to 0, empty, or a very large number
  • remoteHub.indexing.verboseDownloadNotification, configures how loud the progress is, make sure that when this is set false you can still cancel long running downloads by clicking the status bar entry then cancelling in the popup.
@rchiodo
Copy link
Contributor

rchiodo commented Feb 23, 2022

@JacksonKearl is there a way to clear the flag that indicates whether or not to download?

I did this and didn't get what I expected:

  1. Opened a repository with more than 50MB of files
  2. Went to search
  3. Download started
  4. Download gave a warning at 50
  5. Change maxIndexSize to 1
  6. Closed and reopened VS code
  7. Repeat steps
  8. No warning

How do I get the warning again?

@JacksonKearl
Copy link
Contributor Author

JacksonKearl commented Feb 23, 2022

The Configure indexing of Repositories command should give you a picker with those options. Alternatively the `Delete all repository indexes" command will clean you slate too.

@rchiodo
Copy link
Contributor

rchiodo commented Feb 23, 2022

Neither of those seem to work. It never downloads again unless I explicitly click the 'Enable indexing' link.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants