Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WorkspaceConfiguration.update should warn when setting invalid values #12811

Closed
Tyriar opened this issue Sep 27, 2016 · 2 comments
Closed

WorkspaceConfiguration.update should warn when setting invalid values #12811

Tyriar opened this issue Sep 27, 2016 · 2 comments
Assignees
@bpasero @jrieken
Labels
api info-needed Issue requires more information from poster invalid Issue identified as not relevant or not valid

Comments

@Tyriar
Copy link
Member

Tyriar commented Sep 27, 2016 •
edited
Loading

Steps to Reproduce:

The following does nothing and doesn't warn:

vscode.workspace.getConfiguration().update('terminal.integrated', false, true)

At the least I would expect a console message.
@Tyriar Tyriar added the api label Sep 27, 2016
@jrieken jrieken added the info-needed Issue requires more information from poster label Sep 28, 2016
@jrieken
Copy link
Member

jrieken commented Sep 28, 2016

@Tyriar Can you be a little more specific?

@bpasero
Copy link
Member

bpasero commented Sep 28, 2016

@Tyriar you have to handle the error case of the promise you get:

image

@bpasero bpasero closed this as completed Sep 28, 2016
@bpasero bpasero added the invalid Issue identified as not relevant or not valid label Sep 28, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

@jrieken jrieken

Labels
api info-needed Issue requires more information from poster invalid Issue identified as not relevant or not valid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bpasero @jrieken @Tyriar