Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize notebook API (part 2) #125758

Closed
jrieken opened this issue Jun 8, 2021 · 4 comments
Closed

Finalize notebook API (part 2) #125758

jrieken opened this issue Jun 8, 2021 · 4 comments
Assignees
Labels
api-finalization *duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality notebook-api

Comments

@jrieken
Copy link
Member

jrieken commented Jun 8, 2021

There is more API to be finalized

  • the NotebookEditor API and its friends
  • IPC for controllers and renderers
  • various event for when notebook change etc
@jrieken jrieken self-assigned this Jun 8, 2021
@jrieken jrieken added feature-request Request for new features or functionality notebook labels Jun 8, 2021
@jrieken jrieken modified the milestones: Backlog, June 2021 Jun 8, 2021
@jrieken jrieken modified the milestones: June 2021, July 2021 Jun 23, 2021
@jrieken jrieken removed this from the July 2021 milestone Jul 12, 2021
@rebornix rebornix removed the notebook label Oct 21, 2021
@bxantus
Copy link

bxantus commented Dec 2, 2021

Could you provide us with some updates regarding this issue?
It's really unconfortable for our users to use Insiders and opt-in for proposed APIs, so we use only the finalized APIs.

But without the NotebookEditor API I can't change metadata associated with the cells. Prepopulating the metadata from the NotebookSerializer when opening documents works, but only for existing cells...
I personally can't see why editing JSON compatible metadata can't be added to the final API. As I see it, the proposed API hasn't changed in a while in this regard...

@gjsjohnmurray
Copy link
Contributor

The proposed API keyed on notebookEditor must also be enabled if an extension wants to contribute to the interactive/toolbar and interactive/cell/title menus, despite these being documented amongst finalized menu contribution points.

Also, the comment in vscode.proposed.notebookEditor.d.ts points to a stale closed issue. It would do better pointing here.

@mjbvz
Copy link
Collaborator

mjbvz commented Jun 9, 2022

Now tracked by #149861

@mjbvz mjbvz closed this as completed Jun 9, 2022
@mjbvz mjbvz added the *duplicate Issue identified as a duplicate of another issue(s) label Jun 9, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api-finalization *duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality notebook-api
Projects
None yet
Development

No branches or pull requests

7 participants
@rebornix @jrieken @bxantus @gjsjohnmurray @tanhakabir @mjbvz and others