Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate the new semantic highlighter for TS #119139

Closed
aeschli opened this issue Mar 16, 2021 · 2 comments
Closed

Validate the new semantic highlighter for TS #119139

aeschli opened this issue Mar 16, 2021 · 2 comments
Assignees
Labels
on-testplan plan-item VS Code - planned item for upcoming typescript Typescript support issues
Milestone

Comments

@aeschli
Copy link
Contributor

aeschli commented Mar 16, 2021

Validate and enable the new semantic highlighter for TS

@aeschli aeschli self-assigned this Mar 16, 2021
@aeschli aeschli transferred this issue from microsoft/vscode-remote-release Mar 16, 2021
@aeschli aeschli added the typescript Typescript support issues label Mar 16, 2021
@aeschli aeschli added this to the March 2021 milestone Mar 16, 2021
@aeschli aeschli added the plan-item VS Code - planned item for upcoming label Mar 16, 2021
@aeschli
Copy link
Contributor Author

aeschli commented Mar 16, 2021

Fixed by c09b3d2

@aeschli
Copy link
Contributor Author

aeschli commented Mar 16, 2021

@mjbvz FYI

I tested the TS implementation against the existing tests in https://github.com/aeschli/typescript-vscode-sh-plugin

typescript-vscode-sh-plugin will no longer intercept for TS >= 4.2 (but will stick around a while to support older versions)

@aeschli aeschli closed this as completed Mar 16, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
on-testplan plan-item VS Code - planned item for upcoming typescript Typescript support issues
Projects
None yet
Development

No branches or pull requests

1 participant