Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A single task can launch many times if running multiple times while window is loading #118238

Closed
Tyriar opened this issue Mar 5, 2021 · 8 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) tasks Task system issues
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Mar 5, 2021

I had a particularly slow start up just now and I hit ctrl+shift+b a bunch of times, once everything settled it launched 3x for each task:

image

Version: 1.55.0-insider (user setup)
Commit: 0477036
Date: 2021-03-05T15:40:03.281Z
Electron: 11.3.0
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: 8.7.220.31-electron.0
OS: Windows_NT x64 10.0.19042

@alexr00 alexr00 added bug Issue identified by VS Code Team member as probable bug tasks Task system issues labels Mar 9, 2021
@alexr00 alexr00 modified the milestones: March 2021, April 2021 Mar 9, 2021
@alexr00
Copy link
Member

alexr00 commented Mar 12, 2021

This is going to require a lot of refactoring to solve. Will try to tackle next debt week.

@alexr00
Copy link
Member

alexr00 commented Apr 16, 2021

Found a simple way to solve it.

@alexr00 alexr00 added the author-verification-requested Issues potentially verifiable by issue author label Apr 16, 2021
@Tyriar
Copy link
Member Author

Tyriar commented Apr 19, 2021

If I try to repro now the default build task no longer works, ctrl+shift+b only shows this now:

image

@Tyriar Tyriar reopened this Apr 19, 2021
@alexr00
Copy link
Member

alexr00 commented Apr 19, 2021

I had reverted the fix since it broke something else. Will try another fix.

@alexr00
Copy link
Member

alexr00 commented Apr 23, 2021

Re-applied the fix and fixed the test that it revealed a bug in.

@Tyriar
Copy link
Member Author

Tyriar commented Apr 26, 2021

@alexr00 the issue I hit is still happening in:

Version: 1.56.0-insider (user setup)
Commit: 633562d
Date: 2021-04-26T05:14:38.204Z
Electron: 12.0.4
Chrome: 89.0.4389.114
Node.js: 14.16.0
V8: 8.9.255.24-electron.0
OS: Windows_NT x64 10.0.19042

Repro:

  1. Reload vscode repo
  2. ctrl+shift+b quickly

image

@meganrogge
Copy link
Contributor

/duplicate #159640

@vscodenpa vscodenpa added the *duplicate Issue identified as a duplicate of another issue(s) label Dec 12, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) tasks Task system issues
Projects
None yet
Development

No branches or pull requests

5 participants
@Tyriar @meganrogge @alexr00 @vscodenpa and others