Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick opened files should be kept open, not previewed #11789

Closed
bgashler1 opened this issue Sep 9, 2016 · 1 comment
Closed

Quick opened files should be kept open, not previewed #11789

bgashler1 opened this issue Sep 9, 2016 · 1 comment
Labels
feature-request Request for new features or functionality ux User experience issues

Comments

@bgashler1
Copy link
Contributor

  • VSCode Version: 1.4.0
  • OS Version: macOS

Desired behavior

When you use Quick Open (Cmd + P) to open a file, that file should stay open (i.e. it shouldn't be a preview tab).

Current behavior

Current behavior opens it as a preview tab, which can be undesirable. If you open a lot of files up front through quick open, you have to double click the tab or run command "Keep Open" for each file. It makes it very slow to open a lot of files from Quick Open.

sep-09-2016 10-42-30

Since some people may want to rapidly preview a lot of files, then we should do what Sublime does in their version of Quick Open: upon keyboard focus or hover of any file in Quick Open, a preview tab is shown. Only when you press Enter or click does it keep it as an editor and close the Quick Open.

If we click away from or press Escin Quick Open, then this preview tab would close, unless there already was a preview tab open before using Quick Open (in that case the previously previewed file would appear as if nothing had ever happened, so we don't leave a mess).

@bgashler1 bgashler1 added feature-request Request for new features or functionality ux User experience issues labels Sep 9, 2016
@bpasero
Copy link
Member

bpasero commented Sep 9, 2016

The setting workbench.editor.enablePreviewFromQuickOpen controls this. Otherwise this looks like a duplicate of #8939

@bpasero bpasero closed this as completed Jan 5, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality ux User experience issues
Projects
None yet
Development

No branches or pull requests

2 participants