-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sluggish scrolling in notebook windows [monaco editor restore] #117644
Comments
Could you please try following to provide more info to help troubleshoot?
|
CPU profile attached. Sorry for the delay. |
The cpu profile doesn't seem to give us enough info about why it's sluggish, @oscarrutt do you mind try "Performance" recording in Dev Tools? |
Should I scroll while the profile is recording? Also, should I --disable-gpu as before? |
Here is a recording of about a minute in VSCode-Insiders. I vigorously scrolled the Julia notebook in the left tab which was about 1/4 to 1/3 of the screen width, with the Dev Tools tab occupying most of the screen. (BTW, VSC-Insiders leaves one orphaned Python and two orphaned Julia processes after it quits. They have to be manually killed. I believe this also happens after a window crash. Not sure what happens with VSCode. Should I make a separate ticket?) |
Hi @oscarrutt, could you please check if the issue is still present in VS Code 1.57? |
Well, it's complicated. VSC 1.57.0 crashes the extension host on some computers including mine #126031 et al. This also happens with VSC-insiders 1.58.0 which I just downloaded. Version: 1.58.0-insider and also an older VSC-insiders 1.58.0 Version: 1.58.0-insider So this means that I can't run the Jupyter extension in either VSC 1.57.0 or VSC-insiders 1.58-0 and so I can't answer your question until the other problem gets fixed. |
@oscarrutt thanks for sharing the log, the log is actually pretty helpful. It indicates that the scrolling was slowed by the monaco editor instances, which are usually fast to create and restored Did you record this with gpu disabled? |
if you get a chance to use the latest Stable or Insiders, it should be a bit faster as now we move the markdown rendering into webview, which should hurt the performance of scrolling anymore. |
@rebornix Tested now with Insiders as below. (Current Insiders no longer crashes the extensions host upon launch as it did for many macOS users.) Version: 1.58.0-insider I just now tested without gpu disabled and with code-insiders --disable-gpu. I don't notice a difference in scrolling behavior in either case. Sorry. |
@oscarrutt thanks for the info, I think I know what's going on now. |
I met the same issue. Scrolling is very sluggish! Everything is fine except notebook. Version: 1.59.0 |
@xietx1995 is it slow when you run VS Code with gpu disabled? |
Yes, it is. But it's a little bit smoother without GPU acceleration. I tried the same notebook file on an M1 MacBook Pro, and there is no lag. |
Any update on these? Version: 1.59.0 Using 2018 Macbook Pro. |
No change here. Just updated to 1.61.0 Insiders. Version: 1.61.0-insider |
I noticed scrolling in a large py file uses 15~20% GPU in the task manager, but scrolling in a jupyter file uses ~45% GPU. Version: 1.60 |
Same issue here. The scrolling is very jittery and sluggish. And it only happens in .ipynb (notebook) files. Version: 1.60 Mac OS: Big Sur, Version 11.5.2 (20G95) |
Same here. Not very delighting to use compared with JupyterLab Version: 1.60.0 |
This issue has been biting me too. Scrolling is bad enough to make it almost unusable. Version: 1.60.0 |
It seems that the lagginess becomes even more pronounced when the notebook is viewed on large displays. Consequently, by making the window very small, the lag almost completely (yet not quite) disappears. And this effect too is apparent only with .ipynb files (other text based files, including the terminal, remain without any noticeable lag, even when viewed in large resolution). |
We just pushed some changes to improve the scrolling performance (mostly around forced reflow #126880 (comment)). It fixes slugging scrolling for some but not all, but it would be really great if you can try the latest Insiders and see if you are still seeing the same slowness. If so, can you please follow the step here https://github.com/microsoft/vscode/wiki/Performance-Issues#sluggish-ui and share the log with us so we can dig into which operation is the most costly one? |
I don't see any change. Log attached. 13 MB zipped?1? |
Setting "disable-hardware-acceleration": true in argv.json solved the problem for me. Otherwise there is very significant scrolling lag with python notebooks, even after clearing output of all cells. Version: 1.62.3 (system setup) |
heshamg When I set "disable-hardware-acceleration": true and relaunch, I get empty editor windows--nothing but title bar, status bar, and activity bar but with no icons. No tabs. The content area is blank. macOS 10.11.6. VSC 1.63. |
I'm experiencing the same slow scrolling as everyone else with Python notebooks in VSCode. I followed @heshamg's suggestion to use Version: 1.63.2 |
@rebornix I'm experiencing sluggish scrolling in a notebook. Any chance you could help me out? I'm a huge fan of VSCode and use it for everything except notebooks atm because of this issue. I've tried:
Here is a performance profile while scrolling a few times: Profile-20230411T171625.json.zip
|
I'm still experiencing slow scrolling in jupyter notebooks.
I've seen other suggestions such as holding down Version: 1.80.1 (user setup) |
alt + scroll works when your focus is within a code cell. When you scroll past it and let the window renders, the alt trick stops working. (as of version 1.87.2) |
Any progress on this issue? I have attempted the following, but the laggy scrolling still persists:
I also noticed that I couldn't reproduce the lagginess in notebooks that contain only executed markdown cells. The lagginess appears if there is either
It looks like the cells don't even have to be particularly complicated—a few empty code cells or cells with, for example, As a final note, I want to reiterate that this issue only appears in Jupyter notebooks in VSCode. Plain text files in VSCode or other scrollable elements on my OS scroll just fine. This includes the JupyterLab web-based IDE on Safari where the scrolling is without issues. Version: 1.88.0 |
@oscarrutt commented on Mon Feb 22 2021
Scrolling in Jupyter notebook windows is sluggish, laggy, and jumpy. It's not horrible but it is bad enough to cause stress, aggravation, and fatigue. Scrolling is nowhere as nice as in other applications when you get that "massless" feeling. JupyterLab in Firefox is an example of a Jupyter notebook that runs in a cross-platform environment that scrolls nearly perfectly. The problem appears when scrolling with either two-finger drag on the trackpad or click-dragging the thumb bar in the elevator region.
My computer runs macOS 10.11.6. This is an older version of the OS but it should have no effect on scrolling since all other apps scroll well.
I'm using Jupyter in VSCode Insiders to write Julia. I don't know if the problem extends to non-Julia notebooks.
Version: 1.53.0-insider
Commit: 8490d3d
Date: 2021-02-03T15:52:19.585Z
Electron: 11.2.1
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: 8.7.220.31-electron.0
OS: Darwin x64 15.6.0
@jaymegordo commented on Mon Feb 22 2021
+1 I've noticed this as well since I started using insiders + native notebooks. (both python and R)
Version: 1.54.0-insider
Commit: 11cd760
Date: 2021-02-22T06:44:36.656Z
Electron: 11.2.3
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: 8.7.220.31-electron.0
OS: Darwin x64 20.3.0
@DavidKutu commented on Mon Feb 22 2021
Thanks for letting us know @oscarrutt. I checked on a windows 10 laptop and couldn't feel a difference. I'll make sure to have someone test it with a mac.
@DavidKutu commented on Wed Feb 24 2021
@oscarrutt and @jaymegordo, does this only happen with native notebooks? Does it happen say, on a regular python file in vs code?
@jaymegordo commented on Wed Feb 24 2021
@DavidKutu I remember really noticing jittery/slow scrolling when I switched from "old notebooks" to native notebooks a few moths ago. In a standard large python file I can scroll top-bottom in a fraction of a second, but in a NN there's definitely a bit more resistence. I assume this is probably just related to rendering all the extra assets (tables/charts etc). I think the NN scrolling has improved since I first started using it, but I cant actually compare to the old notebooks right now because they don't even work in my stable vscode (I think its something related to "experimental" settings, haven't had time or need to make it work). Its not horrible, just makes me a bit more hesitant to want to scroll around quickly.
So in summary, NN scrolling is definitely slower than a regular python file, but could just be the extra stuff to render. If I can get my old notebooks working I'll try and give a side by side comparison.
@oscarrutt commented on Wed Feb 24 2021
@DavidKutu It does not happen with a regular Python file. As far as I can tell it does not happen with any text file in either vsc or vsc-i.
But to be clear, as far as I can tell, no text file in either vsc or vsc-i scrolls as well as in a native Mac app. One does not have to look far: TextEdit, XCode, or even the Quick Look window in Finder. It's just that the problem as reported here is past the point of acceptability IMO.
I can (now!) open Julia native notebooks in vsc. (I thought that wasn't possible a week ago. Am I confused? The display is different, with different backgrounds and widgets but no syntax coloring in vsc.) In any case, my Julia native notebooks seem to scroll as well in vsc as text scrolls in vsc. Hope this isn't too confusing.
The text was updated successfully, but these errors were encountered: