Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier to switch between menu bar locations #116142

Closed
sbatten opened this issue Feb 8, 2021 · 5 comments
Closed

Make it easier to switch between menu bar locations #116142

sbatten opened this issue Feb 8, 2021 · 5 comments
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded web Issues related to running VSCode in the web
Milestone

Comments

@sbatten
Copy link
Member

sbatten commented Feb 8, 2021

There are 2 possible locations for the menu bar: the title bar and the activity bar.

We should make it easier to move between these settings from the menu location itself.

@sbatten sbatten self-assigned this Feb 8, 2021
@sbatten sbatten added this to the February 2021 milestone Feb 8, 2021
@sbatten
Copy link
Member Author

sbatten commented Feb 8, 2021

Options:

Context Menu on the Title Bar
image

Appearance Menu Entry
image

Activity Bar Context Menu
image

An Icon Button
image

@sbatten sbatten added the web Issues related to running VSCode in the web label Feb 8, 2021
@bpasero
Copy link
Member

bpasero commented Feb 9, 2021

I find the context menu on our custom title slightly irritating because I would expect the OS native entries in there for window management. I think we should actually try to get as many of those native actions supported as possible (e.g. like "Minimize Window").

image

@bpasero
Copy link
Member

bpasero commented Feb 9, 2021

Actually nevermind, we seem to support the native menu:

image

So I think having a custom context menu is not an option.

@sbatten
Copy link
Member Author

sbatten commented Feb 9, 2021

@bpasero, yes agreed about the native menu, alternatively I could put the custom context menu only on the menu itself or only in web

@sbatten
Copy link
Member Author

sbatten commented Feb 11, 2021

New behavior:
✔️ Show Menu Bar => classic
🚫 ✔️ Show Menu Bar => compact
When menu bar is not visible or compact, use the activity bar context menu to hide fully (toggle mode)

@sbatten sbatten added feature-request Request for new features or functionality verification-needed Verification of issue is requested labels Feb 22, 2021
@jrieken jrieken added the verified Verification succeeded label Feb 23, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded web Issues related to running VSCode in the web
Projects
None yet
Development

No branches or pull requests

4 participants
@bpasero @jrieken @sbatten and others