Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hover: clicking on a source link does not work in web #115381

Closed
bpasero opened this issue Jan 29, 2021 · 1 comment
Closed

Hover: clicking on a source link does not work in web #115381

bpasero opened this issue Jan 29, 2021 · 1 comment
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug editor-hover Editor mouse hover upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream web Issues related to running VSCode in the web

Comments

@bpasero
Copy link
Member

bpasero commented Jan 29, 2021 •
edited
Loading

Steps to Reproduce:

  1. open vscode.d.ts in web selfhost
  2. hover over something that has a link
  3. click it

image

=>

image
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug editor-hover Editor mouse hover web Issues related to running VSCode in the web labels Jan 29, 2021
@mjbvz
Copy link
Collaborator

mjbvz commented Jan 29, 2021

These links also doesn't work on desktop (the links are in a special format the only our built-in extension editing extension understand):

Screen Shot 2021-01-29 at 1 18 57 PM

We are tracking microsoft/TypeScript#35524 which would let us use standard JSDoc tags for links instead

@mjbvz mjbvz closed this as completed Jan 29, 2021
@mjbvz mjbvz added upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream labels Jan 29, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug editor-hover Editor mouse hover upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream web Issues related to running VSCode in the web
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bpasero @mjbvz