Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception breakpoints don't show up sometimes #115121

Closed
TylerLeonhardt opened this issue Jan 26, 2021 · 7 comments
Closed

Exception breakpoints don't show up sometimes #115121

TylerLeonhardt opened this issue Jan 26, 2021 · 7 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone

Comments

@TylerLeonhardt
Copy link
Member

Testing #114345

Clone: https://github.com/microsoft/vscode-mock-debug
Open it and run the mock debug extension.

Expected the Exception breakpoints to show up under breakpoints.

Actual (nothing there):
image

I briefly repro'd this with the JS debugger when I got the nightly but now I don't see this issue anymore.

Workaround

Run a debug session, they show up:

image

After I reload the window, they disappear again.

@isidorn isidorn added this to the January 2021 milestone Jan 27, 2021
@isidorn isidorn added debug Debug viewlet, configurations, breakpoints, adapter issues bug Issue identified by VS Code Team member as probable bug labels Jan 27, 2021
@isidorn
Copy link
Contributor

isidorn commented Jan 27, 2021

@TylerLeonhardt great catch, thanks for filling good issues

@connor4312
Copy link
Member

Please verify tomorrow if you can, not sure how 'sometimes' the 'sometimes' is 🙂

@isidorn
Copy link
Contributor

isidorn commented Jan 28, 2021

I suggest to verify with mock-debug since for that sometimes = always

@TylerLeonhardt
Copy link
Member Author

TylerLeonhardt commented Jan 28, 2021

@isidorn I still don't see them:

image

They don't show up until after the first debug session.

Version: 1.53.0-insider (user setup)
Commit: 2ce2664
Date: 2021-01-28T13:54:01.170Z
Electron: 11.2.1
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: 8.7.220.31-electron.0
OS: Windows_NT x64 10.0.19042

@isidorn
Copy link
Contributor

isidorn commented Jan 28, 2021

That is expected. Exception breakpoints are coming from the debug adapter. Thus we only know them on the very first session that you start.
However if you do not see them after you have debugged in the workspace than that is an issue, since we should store them in storage. If this is the case let me know and I can reopen. Thanks

Clarification: if you debugged once. Close vscode and start it again they should be there.

@isidorn isidorn closed this as completed Jan 28, 2021
@TylerLeonhardt
Copy link
Member Author

Thanks for the clarification! This bug is fixed.

@isidorn
Copy link
Contributor

isidorn commented Jan 28, 2021

Great, adding verified label

@isidorn isidorn added the verified Verification succeeded label Jan 28, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants
@isidorn @connor4312 @TylerLeonhardt and others