Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line breakpoints don't show same info as Function breakpoints #115109

Closed
TylerLeonhardt opened this issue Jan 26, 2021 · 3 comments
Closed

Line breakpoints don't show same info as Function breakpoints #115109

TylerLeonhardt opened this issue Jan 26, 2021 · 3 comments
Assignees
Labels
*as-designed Described behavior is as designed debug Debug viewlet, configurations, breakpoints, adapter issues under-discussion Issue is under discussion for relevance, priority, approach

Comments

@TylerLeonhardt
Copy link
Member

Testing #114345

If I add an expression and hit count to a line breakpoint, shouldn't that also show here?

image

@isidorn
Copy link
Contributor

isidorn commented Jan 26, 2021

For line brekapoints we use that space to show its relative workspace path. In this particualar case you have a file which is in the root so the path is empty.

In theory we coudl show the condition if the path is empty - which I find bad and inconsistent.
A better alternative is to show a path only if the breakpoint has no condition. Otherwise show the conditions since it is more important. And show path on hover.
Currently we do it the other way around - path inline and condition on hover.

For now I would not change anything here, but I am open for ideas..

@isidorn isidorn added debug Debug viewlet, configurations, breakpoints, adapter issues under-discussion Issue is under discussion for relevance, priority, approach labels Jan 26, 2021
@TylerLeonhardt
Copy link
Member Author

I think that makes sense. I'm fine with that answer. Feel free to close.

@isidorn
Copy link
Contributor

isidorn commented Jan 27, 2021

Okey. Let's close as designed

@isidorn isidorn closed this as completed Jan 27, 2021
@isidorn isidorn added the *as-designed Described behavior is as designed label Jan 27, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*as-designed Described behavior is as designed debug Debug viewlet, configurations, breakpoints, adapter issues under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

2 participants