Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode Insdier for ARM64 on M1 Macmini SOURCE CONTROL is slowly #113660

Closed
stilleshan opened this issue Jan 1, 2021 · 11 comments
Closed

VSCode Insdier for ARM64 on M1 Macmini SOURCE CONTROL is slowly #113660

stilleshan opened this issue Jan 1, 2021 · 11 comments
Assignees
Labels
🍎 si Issues related to apple silicon bug Issue identified by VS Code Team member as probable bug perf upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Milestone

Comments

@stilleshan
Copy link

  • VSCode Version:1.53.0-insider
  • OS Version:Darwin arm64 20.2.0

Steps to Reproduce:

1.Open Github folder
2.SOURCE CONTROL is very slow to refresh

When i use VSCode stable on M1 Macmini the SOURCE CONTROL is very fast
But it is very slow when i use VSCode Insider for ARM64

@eamodio
Copy link
Contributor

eamodio commented Jan 4, 2021

@deepak1556 any idea on this one?

@deepak1556
Copy link
Collaborator

Can you provide the performance profile from both stable and insider following, thanks!

  • Execute "F1 > Toggle Developer Tools."
  • Select 'Performance' tab
  • Start the profiler and perform the actions for slowdown
  • Save the profile to a file and attach here.

@deepak1556 deepak1556 added 🍎 si Issues related to apple silicon info-needed Issue requires more information from poster perf labels Jan 4, 2021
@stilleshan
Copy link
Author

@deepak1556
Thanks for your reply.
profile.zip

@deepak1556 deepak1556 removed the info-needed Issue requires more information from poster label Jan 5, 2021
@rzhao271 rzhao271 added the bug Issue identified by VS Code Team member as probable bug label Jan 8, 2021
@seloner
Copy link

seloner commented Jan 26, 2021

I have the same issue,any fix?

@deepak1556
Copy link
Collaborator

This is pending fix from upstream electron/electron#27026

@deepak1556 deepak1556 added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Jan 27, 2021
@eamodio eamodio removed their assignment Jan 27, 2021
@stilleshan
Copy link
Author

When i update macOS 11.2 today , The extension "Bracket Pair Colorizer 2" makes vscode - insiders an error "Extension host terminated unexpectedly" .

When i uninstalled it , I found "SOURCE CONTROL" has back to normal

截屏2021-02-02 14 26 19

@seloner
Copy link

seloner commented Feb 2, 2021

I confirm with mac os 11.2 the performance is much better.

@deepak1556
Copy link
Collaborator

@stilleshan the extension host crash is tracked at #115646

@deepak1556
Copy link
Collaborator

@stilleshan can you check if the original issue of perf regression with source control is seen with latest insiders ? Thanks!

@stilleshan
Copy link
Author

stilleshan commented Feb 6, 2021

@deepak1556

The performance has returned to normal now . even faster than vscode stable for intel .

  • macOS 11.2 (M1 Mac mini)
  • VSCode insader ARM
    Version: 1.54.0-insider
    Commit: 52838cf
    Date: 2021-02-05T05:17:08.594Z (21 hrs ago)
    Electron: 11.2.2
    Chrome: 87.0.4280.141
    Node.js: 12.18.3
    V8: 8.7.220.31-electron.0
    OS: Darwin arm64 20.3.0

@deepak1556
Copy link
Collaborator

Thanks for confirming!

@deepak1556 deepak1556 added this to the February 2021 milestone Feb 6, 2021
@roblourens roblourens added the verified Verification succeeded label Feb 25, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🍎 si Issues related to apple silicon bug Issue identified by VS Code Team member as probable bug perf upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

6 participants