Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate removal of enable-proposed-api command line argument #110729

Closed
jrieken opened this issue Nov 16, 2020 · 4 comments
Closed

Investigate removal of enable-proposed-api command line argument #110729

jrieken opened this issue Nov 16, 2020 · 4 comments
Assignees
Labels
api debt Code quality issues feature-request Request for new features or functionality

Comments

@jrieken
Copy link
Member

jrieken commented Nov 16, 2020

Follow-up from #110617 and countless related discussions.

Today, proposed API can be used by extensions when

  1. running out of sources
  2. when an extension is built into vscode (./extensions-folder)
  3. when developing an extension
  4. when adding an extension to the allow list in product.json
  5. when using the --enable-proposed-api <extension-id>

The primary goal is to remove option 2 and 5. A stretch goal is to have a process for how to onboard extensions to be in the product.json allow list.

@jrieken jrieken self-assigned this Nov 16, 2020
@jrieken jrieken added this to the November 2020 milestone Nov 16, 2020
@jrieken jrieken added api debt Code quality issues labels Nov 16, 2020
@jrieken
Copy link
Member Author

jrieken commented Nov 16, 2020

To shed some light on the "why".

We have added proposed API for two reasons

  1. get feedback from extension author while working on an API
  2. take out pressure to finish API work within one iteration

The latter works well for us and vscode.proposed.d.ts has become the place in which API development happens. The former doesn't work very well. We get very little feedback on API and I don't want to blame anyone for that. For an extension author the function of an API is important and they are happy when it does its job. An API being consistent with other APIs and in-line with our guidelines is usually a non-goal or of little interest. However, requests for allowing to consume proposed API more freely is a constant distractor and something that doesn't align with our API process. These requests originate from the "feature" of freely allowing anyone to use proposed API via a command line flag and that must be reconsidered

@gjsjohnmurray
Copy link
Contributor

We get very little feedback on API

When extension developers who have tested a proposed API and are happy with it, but the sponsor isn't but doesn't say why not, what's to be done?

#59921 (comment)

@jrieken
Copy link
Member Author

jrieken commented Nov 16, 2020

but the sponsor isn't but doesn't say why not, what's to be done?

For that specific case I have no good answer and I do share the frustration

@jrieken jrieken added the feature-request Request for new features or functionality label Nov 27, 2020
@jrieken jrieken removed this from the January 2021 milestone Dec 16, 2020
@jrieken
Copy link
Member Author

jrieken commented Jun 25, 2021

This will not happen

@jrieken jrieken closed this as completed Jun 25, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api debt Code quality issues feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

3 participants