Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken Gif for new extension #108911

Closed
sunliangqin opened this issue Oct 19, 2020 · 5 comments
Closed

Broken Gif for new extension #108911

sunliangqin opened this issue Oct 19, 2020 · 5 comments
Assignees
Labels
marketplace Microsoft VS Code Marketplace issues

Comments

@sunliangqin
Copy link

sunliangqin commented Oct 19, 2020

I just published a new extension and noticed that the gif file was broken in the extension details view.

image

From the debugging tool, it looks like the generated link to the gif file is incorrect. It references files in the master branch. However, now for new repositories github uses main as default branch name (See https://github.com/github/renaming). so the correct link should be https://github.com/sunliangqin/VSCodeQuickJump/raw/main/assets/demo.gif
image

@sunliangqin
Copy link
Author

The gif file is also broken in the visual studio marketplace website.
image

@sandy081 sandy081 assigned fiveisprime and unassigned sandy081 Oct 19, 2020
@sandy081 sandy081 added the marketplace Microsoft VS Code Marketplace issues label Oct 19, 2020
@sandy081
Copy link
Member

@prashantvc FYI

@prashantvc
Copy link
Contributor

Marketplace does not resolve URLs, we use only absolute paths.
vsce generates path for links in the README file, you can use --githubBranch to override the branch name.

see microsoft/vscode-vsce#504 (comment)

@sunliangqin
Copy link
Author

Good to know. Thanks. Is it possible for the tool to auto detect the branch name or show an error if the branch/generated link doesn't exist?

@fiveisprime
Copy link
Member

This is being tracked here: microsoft/vscode-vsce#534

@github-actions github-actions bot locked and limited conversation to collaborators Apr 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
marketplace Microsoft VS Code Marketplace issues
Projects
None yet
Development

No branches or pull requests

4 participants