Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report trusted type violation during build and in editor #104489

Closed
jrieken opened this issue Aug 12, 2020 · 2 comments
Closed

Report trusted type violation during build and in editor #104489

jrieken opened this issue Aug 12, 2020 · 2 comments
Assignees
Labels
engineering VS Code - Build / issue tracking / etc.

Comments

@jrieken
Copy link
Member

jrieken commented Aug 12, 2020

Part of #103699 should be to make trusted types violations visible so that

  • devs don't re-introduce violations that have been fixed already
  • violations become visible and are fixed by devs themselves

One candidate would be the tsec-tool: https://github.com/googleinterns/tsec, e.g run it during builds and on dev-boxes

@jrieken jrieken self-assigned this Aug 12, 2020
@jrieken jrieken added the engineering VS Code - Build / issue tracking / etc. label Aug 12, 2020
@koto
Copy link

koto commented Aug 12, 2020

That sounds good! I am not sure tsec is good for that just yet, but we're currently improving the engine and its rules to have less false-negatives and false-positives. Adding @Siegrift and @uraj who are working on it.

We want to eventually integrate it into the vscode build toolchain to prevent regressions.

@jrieken
Copy link
Member Author

jrieken commented Nov 10, 2020

Closing since we have everything we need for this. The last and final step will be to cause build failures when TT violations are encountered

@jrieken jrieken closed this as completed Nov 10, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
engineering VS Code - Build / issue tracking / etc.
Projects
None yet
Development

No branches or pull requests

2 participants