Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension details view should show extension contributions #10366

Closed
kieferrm opened this issue Aug 9, 2016 · 7 comments
Closed

Extension details view should show extension contributions #10366

kieferrm opened this issue Aug 9, 2016 · 7 comments
Assignees
Labels
extensions Issues concerning extensions feature-request Request for new features or functionality plan-item VS Code - planned item for upcoming
Milestone

Comments

@kieferrm
Copy link
Member

kieferrm commented Aug 9, 2016

Extensions can contribute commands to the command palette, editor menus, and the explorer context menu. In addition, commands can be bound to keyboard shortcuts.

The extension details view should give users a way to better understand the contributions an extensions makes and if those contributions cause conflicts with core VS Code keyboard shortcuts or with keyboard shortcuts used by other installed extensions.

@kieferrm kieferrm added plan-item VS Code - planned item for upcoming extensions Issues concerning extensions labels Aug 9, 2016
@kieferrm kieferrm added this to the August 2016 milestone Aug 9, 2016
@joaomoreno
Copy link
Member

joaomoreno commented Aug 15, 2016

  • configuration - Display a list of the config property names.
  • commands - Display a list of the command ids.
  • menus - Show a table of the menu labels and context associated with the commands. Maybe combine with the commands table.
  • keybindings - Show a table of the keybindings associated with the commands. Maybe combine with the commands table.
  • languages - Show a table of language ids and file extensions.
  • debuggers - Show a list of the debuggers' labels.
  • grammars - Maybe combine with the languages table?
  • themes - Show a list of the themes' names.
  • snippets - Show whether a language has snippets or not. Maybe combine with the languages table.
  • jsonValidation - Show a list of file matches.

@joaomoreno
Copy link
Member

Maybe each section can be implemented...

using...

the details tag!

@joaomoreno joaomoreno added the feature-request Request for new features or functionality label Aug 17, 2016
@joaomoreno
Copy link
Member

joaomoreno commented Aug 25, 2016

Displaying of contributions is ✅ .

cc @egamma @kieferrm

Conflicts are much harder. While an extension provides a keybinding with a given context, I can't unequivocally say that it will or won't conflict with another existing keybinding that has a different context. The same keybinding might come from two extensions and act in mutually exclusive contexts, thus never conflicting.

Unless there's something @alexandrudima knows and I don't, I suggest to push the conflicts out of this plan item.

@alexdima
Copy link
Member

I have a mini "SMT solver" in there, that's why I kept the language constrained to have only &&. I can prove if one keybinding item absolutely overwrites another keybinding item.

https://github.com/Microsoft/vscode/blob/a3493c75934a67ddadff71818ab8f7201eeb0fbf/src/vs/platform/keybinding/common/keybindingResolver.ts#L205

@joaomoreno
Copy link
Member

Pretty cool, I'll give it a try.

@joaomoreno joaomoreno reopened this Aug 26, 2016
@joaomoreno
Copy link
Member

@alexandrudima Any pointers on how to get a hold of all registered keybindings along with their configured when clause?

@joaomoreno
Copy link
Member

Decided to remove the conflicts out of this plan item.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
extensions Issues concerning extensions feature-request Request for new features or functionality plan-item VS Code - planned item for upcoming
Projects
None yet
Development

No branches or pull requests

3 participants