Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After left panel tree view delete, focus should go on the last file or the file that took its place #1025

Closed
Tyriar opened this issue Dec 4, 2015 · 3 comments
Labels
feature-request Request for new features or functionality file-explorer Explorer widget issues ux User experience issues
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Dec 4, 2015

Selecting and deleting c in this file structure:

  • a
    • b
    • c
    • d

Currently will move focus to a. I would expect this to move focus to d to allow multiple deletes in quick succession, so delete, delete, delete could be used to remove all of a's files before focus is moved to a.

@egamma egamma added feature-request Request for new features or functionality ux User experience issues labels Dec 8, 2015
@egamma egamma modified the milestone: Backlog Dec 10, 2015
@bpasero bpasero added workbench file-explorer Explorer widget issues and removed workbench labels Dec 18, 2015
@bpasero bpasero self-assigned this Mar 30, 2016
@bpasero
Copy link
Member

bpasero commented Jun 6, 2016

@Tyriar but how would that work if you have files open in a stack? Currently when you click the file it opens the file and when you delete it shows the one next on the stack.

@Tyriar
Copy link
Member Author

Tyriar commented Jun 6, 2016

Things have changed a little since I filed this but the behavior described is still the same when the deleted file is not open.

  1. Open some file a
  2. shift+ctrl+e to focus the explorer
  3. Navigate to some file b using the keyboard without pressing enter to activate it
  4. delete, notice focus goes to build instead of one b's closest sibling, it's a little disorienting

So currently it doesn't focus the next file in the stack on the explorer, it opens the next file in the stack in the editor but focuses the parent of the deleted file in the explorer.


Related to this, performing multiple actions with the keyboard within the explorer would probably be easier if we could turn off the auto-focus of the editor (I think it used to be like this) #7257. This coupled with #1023 and #7258, it would be convenient to do some real file/directory manipulation from within VSCode.

@bpasero bpasero removed their assignment Aug 17, 2016
@isidorn
Copy link
Contributor

isidorn commented Nov 17, 2017

This feature request will not be considered in the next 6-12 months roadmap and as such will be closed to keep the number of issues we have to maintain actionable. Thanks for understanding and happy coding!

PRs that fix are welcome

@isidorn isidorn closed this as completed Nov 17, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality file-explorer Explorer widget issues ux User experience issues
Projects
None yet
Development

No branches or pull requests

4 participants