Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider adding a command object to TerminalLink rather than the handleTerminalLink method #101457

Closed
eamodio opened this issue Jun 30, 2020 · 1 comment
Closed

Consider adding a command object to TerminalLink rather than the handleTerminalLink method #101457

eamodio opened this issue Jun 30, 2020 · 1 comment
Assignees
@Tyriar
Labels
api terminal General terminal issues that don't fall under another label terminal-links under-discussion Issue is under discussion for relevance, priority, approach

Comments

@eamodio
Copy link
Contributor

eamodio commented Jun 30, 2020

Testing #101300

Again, this is mostly API ergonomics, but this would keep consistency with other APIs (CodeLens, StatusBarItems, TreeItems, etc). It also helps guide the usage of a command being required to return a link, and somewhat avoids calls to handleTerminalLink that take no action.

Additionally since the command object has a title property, that could be used in place of the tooltip property as well.

re: #101391 (comment)

/cc @jrieken
@Tyriar Tyriar mentioned this issue Jul 1, 2020
Closed
@Tyriar Tyriar added api terminal General terminal issues that don't fall under another label terminal-links under-discussion Issue is under discussion for relevance, priority, approach labels Jul 1, 2020
@Tyriar Tyriar added this to the July 2020 milestone Jul 1, 2020
@Tyriar
Copy link
Member

Tyriar commented Jul 14, 2020

Decided not to do this #91290 (comment)

@Tyriar Tyriar closed this as completed Jul 14, 2020
@Tyriar Tyriar removed this from the July 2020 milestone Jul 14, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
api terminal General terminal issues that don't fall under another label terminal-links under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eamodio @Tyriar