Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider changing TerminalLink endIndex to length #101455

Closed
eamodio opened this issue Jun 30, 2020 · 1 comment
Closed

Consider changing TerminalLink endIndex to length #101455

eamodio opened this issue Jun 30, 2020 · 1 comment
Assignees
@Tyriar
Labels
api bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal General terminal issues that don't fall under another label terminal-links verified Verification succeeded
Milestone
July 2020

Comments

@eamodio
Copy link
Contributor

eamodio commented Jun 30, 2020

Testing #101300

Totally API ergonomics, but since IMO regex is a likely mechanism for finding potential links in a line, it would be nice to not have to add the RegExp.index to the match length.
@Tyriar Tyriar added api terminal General terminal issues that don't fall under another label terminal-links under-discussion Issue is under discussion for relevance, priority, approach labels Jul 1, 2020
@Tyriar Tyriar added this to the July 2020 milestone Jul 1, 2020
@Tyriar
Copy link
Member

Tyriar commented Jul 1, 2020

I liked length as well but changed it to align with (some) other VS Code APIs. The xterm.js API uses length.

@Tyriar Tyriar mentioned this issue Jul 1, 2020
Closed
@Tyriar Tyriar closed this as completed in fe39b1c Jul 15, 2020
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug and removed under-discussion Issue is under discussion for relevance, priority, approach labels Aug 3, 2020
@roblourens roblourens added the verified Verification succeeded label Aug 6, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
api bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal General terminal issues that don't fall under another label terminal-links verified Verification succeeded
Projects
None yet
Milestone
July 2020
Development

No branches or pull requests
4 participants
@roblourens @eamodio @Tyriar and others