Skip to content

Commit 99dd43c

Browse files
isidornisidorn
committed
debug: remove unused locals
#37212
1 parent ebbfbed commit 99dd43c

File tree

10 files changed

+10
-47
lines changed

10 files changed

+10
-47
lines changed

‎src/vs/workbench/parts/debug/browser/debugActions.ts

-2
Original file line numberDiff line numberDiff line change
@@ -77,8 +77,6 @@ export class ConfigureAction extends AbstractDebugAction {
7777
constructor(id: string, label: string,
7878
@IDebugService debugService: IDebugService,
7979
@IKeybindingService keybindingService: IKeybindingService,
80-
// @ts-ignore unused injected service
81-
@IWorkspaceContextService private contextService: IWorkspaceContextService,
8280
@IMessageService private messageService: IMessageService
8381
) {
8482
super(id, label, 'debug-action configure', debugService, keybindingService);

‎src/vs/workbench/parts/debug/browser/debugQuickOpen.ts

-3
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import { TPromise } from 'vs/base/common/winjs.base';
99
import Quickopen = require('vs/workbench/browser/quickopen');
1010
import QuickOpen = require('vs/base/parts/quickopen/common/quickOpen');
1111
import Model = require('vs/base/parts/quickopen/browser/quickOpenModel');
12-
import { IQuickOpenService } from 'vs/platform/quickOpen/common/quickOpen';
1312
import { IDebugService, ILaunch } from 'vs/workbench/parts/debug/common/debug';
1413
import { IWorkspaceContextService, WorkbenchState } from 'vs/platform/workspace/common/workspace';
1514
import * as errors from 'vs/base/common/errors';
@@ -80,8 +79,6 @@ export class DebugQuickOpenHandler extends Quickopen.QuickOpenHandler {
8079
private autoFocusIndex: number;
8180

8281
constructor(
83-
// @ts-ignore unused injected service
84-
@IQuickOpenService private quickOpenService: IQuickOpenService,
8582
@IDebugService private debugService: IDebugService,
8683
@IWorkspaceContextService private contextService: IWorkspaceContextService,
8784
@ICommandService private commandService: ICommandService

‎src/vs/workbench/parts/debug/browser/exceptionWidget.ts

+2-8
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@ import * as nls from 'vs/nls';
88
import * as dom from 'vs/base/browser/dom';
99
import { ZoneWidget } from 'vs/editor/contrib/zoneWidget/browser/zoneWidget';
1010
import { ICodeEditor } from 'vs/editor/browser/editorBrowser';
11-
import { IContextViewService } from 'vs/platform/contextview/browser/contextView';
12-
import { IDebugService, IExceptionInfo } from 'vs/workbench/parts/debug/common/debug';
11+
import { IExceptionInfo } from 'vs/workbench/parts/debug/common/debug';
1312
import { RunOnceScheduler } from 'vs/base/common/async';
1413
import { IThemeService, ITheme } from 'vs/platform/theme/common/themeService';
1514
import { Color } from 'vs/base/common/color';
@@ -27,12 +26,7 @@ export class ExceptionWidget extends ZoneWidget {
2726

2827
private _backgroundColor: Color;
2928

30-
// @ts-ignore unused property
31-
constructor(editor: ICodeEditor, private exceptionInfo: IExceptionInfo, private lineNumber: number,
32-
// @ts-ignore unused injected service
33-
@IContextViewService private contextViewService: IContextViewService,
34-
// @ts-ignore unused injected service
35-
@IDebugService private debugService: IDebugService,
29+
constructor(editor: ICodeEditor, private exceptionInfo: IExceptionInfo,
3630
@IThemeService themeService: IThemeService,
3731
@IInstantiationService private instantiationService: IInstantiationService
3832
) {

‎src/vs/workbench/parts/debug/browser/linkDetector.ts

+1-4
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import * as errors from 'vs/base/common/errors';
99
import { IMouseEvent, StandardMouseEvent } from 'vs/base/browser/mouseEvent';
1010
import * as nls from 'vs/nls';
1111
import { IWorkbenchEditorService } from 'vs/workbench/services/editor/common/editorService';
12-
import { IWorkspaceContextService } from 'vs/platform/workspace/common/workspace';
1312

1413
export class LinkDetector {
1514
private static FILE_LOCATION_PATTERNS: RegExp[] = [
@@ -23,9 +22,7 @@ export class LinkDetector {
2322
];
2423

2524
constructor(
26-
@IWorkbenchEditorService private editorService: IWorkbenchEditorService,
27-
// @ts-ignore unused injected service
28-
@IWorkspaceContextService private contextService: IWorkspaceContextService
25+
@IWorkbenchEditorService private editorService: IWorkbenchEditorService
2926
) {
3027
// noop
3128
}

‎src/vs/workbench/parts/debug/electron-browser/debugConfigurationManager.ts

-7
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ import { IExtensionService } from 'vs/platform/extensions/common/extensions';
2424
import { IJSONContributionRegistry, Extensions as JSONExtensions } from 'vs/platform/jsonschemas/common/jsonContributionRegistry';
2525
import { IConfigurationService } from 'vs/platform/configuration/common/configuration';
2626
import { IFileService } from 'vs/platform/files/common/files';
27-
import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry';
2827
import { IWorkspaceContextService, IWorkspaceFolder } from 'vs/platform/workspace/common/workspace';
2928
import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation';
3029
import { ICommandService } from 'vs/platform/commands/common/commands';
@@ -217,15 +216,9 @@ export class ConfigurationManager implements IConfigurationManager {
217216

218217
constructor(
219218
@IWorkspaceContextService private contextService: IWorkspaceContextService,
220-
// @ts-ignore unused injected service
221-
@IFileService private fileService: IFileService,
222-
// @ts-ignore unused injected service
223-
@ITelemetryService private telemetryService: ITelemetryService,
224219
@IWorkbenchEditorService private editorService: IWorkbenchEditorService,
225220
@IConfigurationService private configurationService: IConfigurationService,
226221
@IQuickOpenService private quickOpenService: IQuickOpenService,
227-
// @ts-ignore unused injected service
228-
@IConfigurationResolverService private configurationResolverService: IConfigurationResolverService,
229222
@IInstantiationService private instantiationService: IInstantiationService,
230223
@ICommandService private commandService: ICommandService,
231224
@IStorageService private storageService: IStorageService,

‎src/vs/workbench/parts/debug/electron-browser/debugEditorContribution.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -389,7 +389,7 @@ export class DebugEditorContribution implements IDebugEditorContribution {
389389
this.exceptionWidget.dispose();
390390
}
391391

392-
this.exceptionWidget = this.instantiationService.createInstance(ExceptionWidget, this.editor, exceptionInfo, lineNumber);
392+
this.exceptionWidget = this.instantiationService.createInstance(ExceptionWidget, this.editor, exceptionInfo);
393393
this.exceptionWidget.show({ lineNumber, column }, 0);
394394
}
395395

‎src/vs/workbench/parts/debug/electron-browser/debugService.ts

+2-7
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,10 @@ import { IExtensionService } from 'vs/platform/extensions/common/extensions';
2626
import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation';
2727
import { FileChangesEvent, FileChangeType, IFileService } from 'vs/platform/files/common/files';
2828
import { IMessageService, CloseAction } from 'vs/platform/message/common/message';
29-
import { IWindowsService, IWindowService } from 'vs/platform/windows/common/windows';
29+
import { IWindowService } from 'vs/platform/windows/common/windows';
3030
import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry';
3131
import { TelemetryService } from 'vs/platform/telemetry/common/telemetryService';
3232
import { TelemetryAppenderClient } from 'vs/platform/telemetry/common/telemetryIpc';
33-
import { ICommandService } from 'vs/platform/commands/common/commands';
3433
import { IStorageService, StorageScope } from 'vs/platform/storage/common/storage';
3534
import * as debug from 'vs/workbench/parts/debug/common/debug';
3635
import { RawDebugSession } from 'vs/workbench/parts/debug/electron-browser/rawDebugSession';
@@ -90,8 +89,6 @@ export class DebugService implements debug.IDebugService {
9089
@IPanelService private panelService: IPanelService,
9190
@IMessageService private messageService: IMessageService,
9291
@IPartService private partService: IPartService,
93-
// @ts-ignore unused injected service
94-
@IWindowsService private windowsService: IWindowsService,
9592
@IWindowService private windowService: IWindowService,
9693
@IBroadcastService private broadcastService: IBroadcastService,
9794
@ITelemetryService private telemetryService: ITelemetryService,
@@ -103,9 +100,7 @@ export class DebugService implements debug.IDebugService {
103100
@IMarkerService private markerService: IMarkerService,
104101
@ITaskService private taskService: ITaskService,
105102
@IFileService private fileService: IFileService,
106-
@IConfigurationService private configurationService: IConfigurationService,
107-
// @ts-ignore unused injected service
108-
@ICommandService private commandService: ICommandService
103+
@IConfigurationService private configurationService: IConfigurationService
109104
) {
110105
this.toDispose = [];
111106
this.toDisposeOnSessionEnd = new Map<string, lifecycle.IDisposable[]>();

‎src/vs/workbench/parts/debug/electron-browser/debugViews.ts

+3-11
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ import { AddWatchExpressionAction, RemoveAllWatchExpressionsAction, AddFunctionB
2424
import { IContextMenuService } from 'vs/platform/contextview/browser/contextView';
2525
import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation';
2626
import { MenuId } from 'vs/platform/actions/common/actions';
27-
import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry';
2827
import { IKeybindingService } from 'vs/platform/keybinding/common/keybinding';
2928
import { IContextKeyService, IContextKey } from 'vs/platform/contextkey/common/contextkey';
3029
import { IListService } from 'vs/platform/list/browser/listService';
@@ -50,11 +49,8 @@ export class VariablesView extends ViewsViewletPanel {
5049
private expandedElements: any[];
5150

5251
constructor(
53-
// @ts-ignore unused property
54-
private options: IViewletViewOptions,
52+
options: IViewletViewOptions,
5553
@IContextMenuService contextMenuService: IContextMenuService,
56-
// @ts-ignore unused injected service
57-
@ITelemetryService private telemetryService: ITelemetryService,
5854
@IDebugService private debugService: IDebugService,
5955
@IKeybindingService keybindingService: IKeybindingService,
6056
@IInstantiationService private instantiationService: IInstantiationService,
@@ -164,8 +160,7 @@ export class WatchExpressionsView extends ViewsViewletPanel {
164160
private settings: any;
165161

166162
constructor(
167-
// @ts-ignore unused property
168-
private options: IViewletViewOptions,
163+
options: IViewletViewOptions,
169164
@IContextMenuService contextMenuService: IContextMenuService,
170165
@IDebugService private debugService: IDebugService,
171166
@IKeybindingService keybindingService: IKeybindingService,
@@ -259,8 +254,6 @@ export class CallStackView extends ViewsViewletPanel {
259254
constructor(
260255
private options: IViewletViewOptions,
261256
@IContextMenuService contextMenuService: IContextMenuService,
262-
// @ts-ignore unused injected service
263-
@ITelemetryService private telemetryService: ITelemetryService,
264257
@IDebugService private debugService: IDebugService,
265258
@IKeybindingService keybindingService: IKeybindingService,
266259
@IInstantiationService private instantiationService: IInstantiationService,
@@ -394,8 +387,7 @@ export class BreakpointsView extends ViewsViewletPanel {
394387
private settings: any;
395388

396389
constructor(
397-
// @ts-ignore unused property
398-
private options: IViewletViewOptions,
390+
options: IViewletViewOptions,
399391
@IContextMenuService contextMenuService: IContextMenuService,
400392
@IDebugService private debugService: IDebugService,
401393
@IKeybindingService keybindingService: IKeybindingService,

‎src/vs/workbench/parts/debug/node/debugAdapter.ts

-3
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,12 @@ import { IJSONSchema, IJSONSchemaSnippet } from 'vs/base/common/jsonSchema';
1515
import { IWorkspaceFolder } from 'vs/platform/workspace/common/workspace';
1616
import { IConfig, IRawAdapter, IAdapterExecutable, INTERNAL_CONSOLE_OPTIONS_SCHEMA } from 'vs/workbench/parts/debug/common/debug';
1717
import { IExtensionDescription } from 'vs/platform/extensions/common/extensions';
18-
import { IConfigurationResolverService } from 'vs/workbench/services/configurationResolver/common/configurationResolver';
1918
import { IConfigurationService } from 'vs/platform/configuration/common/configuration';
2019
import { ICommandService } from 'vs/platform/commands/common/commands';
2120

2221
export class Adapter {
2322

2423
constructor(private rawAdapter: IRawAdapter, public extensionDescription: IExtensionDescription,
25-
// @ts-ignore unused injected service
26-
@IConfigurationResolverService private configurationResolverService: IConfigurationResolverService,
2724
@IConfigurationService private configurationService: IConfigurationService,
2825
@ICommandService private commandService: ICommandService
2926
) {

‎src/vs/workbench/parts/debug/test/node/debugAdapter.test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ suite('Debug - Adapter', () => {
4444

4545
setup(() => {
4646
adapter = new Adapter(rawAdapter, { extensionFolderPath, id: 'adapter', name: 'myAdapter', version: '1.0.0', publisher: 'vscode', isBuiltin: false, engines: null },
47-
null, new TestConfigurationService(), null);
47+
new TestConfigurationService(), null);
4848
});
4949

5050
teardown(() => {

0 commit comments

Comments
 (0)