From 6004a9f71683ec894947f196c9dc60296a5f9fcc Mon Sep 17 00:00:00 2001 From: Connor Peet Date: Mon, 7 Aug 2023 11:46:38 -0700 Subject: [PATCH] debug: put user data dir in home dir, update versions of things (#189855) --- .nvmrc | 2 +- .vscode/launch.json | 1 + build/npm/preinstall.js | 8 ++++---- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/.nvmrc b/.nvmrc index 5cb297e3e4897..0f9eb824458c8 100644 --- a/.nvmrc +++ b/.nvmrc @@ -1 +1 @@ -16.17 +18.15 \ No newline at end of file diff --git a/.vscode/launch.json b/.vscode/launch.json index 6c3fd596f0a20..3bea8e7c076b5 100644 --- a/.vscode/launch.json +++ b/.vscode/launch.json @@ -244,6 +244,7 @@ "--disable-features=CalculateNativeWinOcclusion", "--disable-extension=vscode.vscode-api-tests" ], + "userDataDir": "${userHome}/.vscode-oss-dev", "webRoot": "${workspaceFolder}", "cascadeTerminateToConfigurations": [ "Attach to Extension Host" diff --git a/build/npm/preinstall.js b/build/npm/preinstall.js index 31d2a6d5c30ee..158a4984d3265 100644 --- a/build/npm/preinstall.js +++ b/build/npm/preinstall.js @@ -9,12 +9,12 @@ const majorNodeVersion = parseInt(nodeVersion[1]); const minorNodeVersion = parseInt(nodeVersion[2]); const patchNodeVersion = parseInt(nodeVersion[3]); -if (majorNodeVersion < 16 || (majorNodeVersion === 16 && minorNodeVersion < 17)) { - console.error('\033[1;31m*** Please use node.js versions >=16.17.x and <17.\033[0;0m'); +if (majorNodeVersion < 18 || (majorNodeVersion === 18 && minorNodeVersion < 15)) { + console.error('\033[1;31m*** Please use node.js versions >=18.15.x and <19.\033[0;0m'); err = true; } -if (majorNodeVersion >= 17) { - console.warn('\033[1;31m*** Warning: Versions of node.js >= 17 have not been tested.\033[0;0m') +if (majorNodeVersion >= 19) { + console.warn('\033[1;31m*** Warning: Versions of node.js >= 19 have not been tested.\033[0;0m') } const path = require('path');