Skip to content

Commit 4acd934

Browse files
committed
- Updates conpty microsoft/node-pty#811 - Adds Buffer support to API microsoft/node-pty#812 Part of #269213
1 parent c24799b commit 4acd934

File tree

5 files changed

+11
-13
lines changed

5 files changed

+11
-13
lines changed

package-lock.json

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@
108108
"native-is-elevated": "0.7.0",
109109
"native-keymap": "^3.3.5",
110110
"native-watchdog": "^1.4.1",
111-
"node-pty": "1.1.0-beta35",
111+
"node-pty": "^1.1.0-beta39",
112112
"open": "^10.1.2",
113113
"tas-client-umd": "0.2.0",
114114
"undici": "^7.9.0",

remote/package-lock.json

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

remote/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
"kerberos": "2.1.1",
3434
"minimist": "^1.2.8",
3535
"native-watchdog": "^1.4.1",
36-
"node-pty": "1.1.0-beta35",
36+
"node-pty": "^1.1.0-beta39",
3737
"tas-client-umd": "0.2.0",
3838
"vscode-oniguruma": "1.7.0",
3939
"vscode-regexpp": "^3.1.0",

src/vs/platform/terminal/node/terminalProcess.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -542,9 +542,7 @@ export class TerminalProcess extends Disposable implements ITerminalChildProcess
542542
const object = this._writeQueue.shift()!;
543543
this._logService.trace('node-pty.IPty#write', object.data);
544544
if (object.isBinary) {
545-
// TODO: node-pty's write should accept a Buffer
546-
// eslint-disable-next-line local/code-no-any-casts
547-
this._ptyProcess!.write(Buffer.from(object.data, 'binary') as any);
545+
this._ptyProcess!.write(Buffer.from(object.data, 'binary'));
548546
} else {
549547
this._ptyProcess!.write(object.data);
550548
}

0 commit comments

Comments
 (0)