remove ts-ignore

Author: joaomoreno

src/vs/base/parts/tree/test/browser/treeModel.test.ts

@@ -1439,13 +1439,11 @@ suite('TreeModel - Dynamic data model', () => {
 
 			var gotTimes = 0;
 			var gotListener = dataModel.addListener('gotChildren', (element) => { gotTimes++; });
-			// @ts-ignore unused local
-			var p1, p2;
 
 			var p1Completes = [];
 			dataModel.promiseFactory = () => { return new WinJS.TPromise((c) => { p1Completes.push(c); }); };
 
-			p1 = model.refresh('grandfather');
+			model.refresh('grandfather');
 
 			// just a single get
 			assert.equal(refreshTimes, 1); // (+1) grandfather
@@ -1462,7 +1460,7 @@ suite('TreeModel - Dynamic data model', () => {
 
 			var p2Complete;
 			dataModel.promiseFactory = () => { return new WinJS.TPromise((c) => { p2Complete = c; }); };
-			p2 = model.refresh('father');
+			var p2 = model.refresh('father');
 
 			// same situation still
 			assert.equal(refreshTimes, 3); // (+1) second father refresh
@@ -1517,13 +1515,12 @@ suite('TreeModel - Dynamic data model', () => {
 			var gotTimes = 0;
 			var getListener = dataModel.addListener('getChildren', (element) => { getTimes++; });
 			var gotListener = dataModel.addListener('gotChildren', (element) => { gotTimes++; });
-			// @ts-ignore unused local
-			var p1, p2;
+			var p2;
 
 			var p1Complete;
 			dataModel.promiseFactory = () => { return new WinJS.TPromise((c) => { p1Complete = c; }); };
 
-			p1 = model.refresh('father');
+			model.refresh('father');
 
 			assert.equal(getTimes, 1);
 			assert.equal(gotTimes, 0);

src/vs/workbench/api/electron-browser/mainThreadSCM.ts

@@ -11,8 +11,6 @@ import Event, { Emitter } from 'vs/base/common/event';
 import { assign } from 'vs/base/common/objects';
 import { IDisposable, dispose } from 'vs/base/common/lifecycle';
 import { ISCMService, ISCMRepository, ISCMProvider, ISCMResource, ISCMResourceGroup, ISCMResourceDecorations, ISCMResourceCollection, ISCMResourceSplice } from 'vs/workbench/services/scm/common/scm';
-import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation';
-import { ICommandService } from 'vs/platform/commands/common/commands';
 import { ExtHostContext, MainThreadSCMShape, ExtHostSCMShape, SCMProviderFeatures, SCMRawResourceSplices, SCMGroupFeatures, MainContext, IExtHostContext } from '../node/extHost.protocol';
 import { Command } from 'vs/editor/common/modes';
 import { extHostNamedCustomer } from 'vs/workbench/api/electron-browser/extHostCustomers';
@@ -120,9 +118,7 @@ class MainThreadSCMProvider implements ISCMProvider {
 		private _contextValue: string,
 		private _label: string,
 		private _rootUri: URI | undefined,
-		@ISCMService scmService: ISCMService,
-		// @ts-ignore unused injected service
-		@ICommandService private commandService: ICommandService
+		@ISCMService scmService: ISCMService
 	) { }
 
 	$updateSourceControl(features: SCMProviderFeatures): void {
@@ -257,10 +253,7 @@ export class MainThreadSCM implements MainThreadSCMShape {
 
 	constructor(
 		extHostContext: IExtHostContext,
-		// @ts-ignore unused injected service
-		@IInstantiationService private instantiationService: IInstantiationService,
-		@ISCMService private scmService: ISCMService,
-		@ICommandService private commandService: ICommandService
+		@ISCMService private scmService: ISCMService
 	) {
 		this._proxy = extHostContext.get(ExtHostContext.ExtHostSCM);
 	}
@@ -278,7 +271,7 @@ export class MainThreadSCM implements MainThreadSCMShape {
 	}
 
 	$registerSourceControl(handle: number, id: string, label: string, rootUri: string | undefined): void {
-		const provider = new MainThreadSCMProvider(this._proxy, handle, id, label, rootUri && URI.parse(rootUri), this.scmService, this.commandService);
+		const provider = new MainThreadSCMProvider(this._proxy, handle, id, label, rootUri && URI.parse(rootUri), this.scmService);
 		const repository = this.scmService.registerSCMProvider(provider);
 		this._repositories[handle] = repository;
 

src/vs/workbench/browser/parts/views/treeView.ts

@@ -41,8 +41,7 @@ export class TreeView extends ViewsViewletPanel {
 	private dataProviderElementChangeListener: IDisposable;
 
 	constructor(
-		// @ts-ignore unused property
-		private options: IViewletViewOptions,
+		options: IViewletViewOptions,
 		@IMessageService private messageService: IMessageService,
 		@IKeybindingService keybindingService: IKeybindingService,
 		@IContextMenuService contextMenuService: IContextMenuService,

src/vs/workbench/parts/scm/electron-browser/dirtydiffDecorator.ts

@@ -16,10 +16,8 @@ import * as ext from 'vs/workbench/common/contributions';
 import { CodeEditor } from 'vs/editor/browser/codeEditor';
 import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation';
 import { IMessageService, Severity } from 'vs/platform/message/common/message';
-import { IWorkspaceContextService } from 'vs/platform/workspace/common/workspace';
 import { ITextModelService } from 'vs/editor/common/services/resolverService';
 import { IWorkbenchEditorService } from 'vs/workbench/services/editor/common/editorService';
-import { IModelService } from 'vs/editor/common/services/modelService';
 import { IEditorWorkerService } from 'vs/editor/common/services/editorWorkerService';
 import URI from 'vs/base/common/uri';
 import { IEditorGroupService } from 'vs/workbench/services/group/common/groupService';
@@ -194,8 +192,7 @@ class DirtyDiffWidget extends PeekViewWidget {
 		private model: DirtyDiffModel,
 		@IThemeService private themeService: IThemeService,
 		@IInstantiationService private instantiationService: IInstantiationService,
-		// @ts-ignore unused injected service
-		@IMenuService private menuService: IMenuService,
+		@IMenuService menuService: IMenuService,
 		@IKeybindingService private keybindingService: IKeybindingService,
 		@IMessageService private messageService: IMessageService,
 		@IContextKeyService contextKeyService: IContextKeyService
@@ -468,8 +465,6 @@ export class DirtyDiffController implements IEditorContribution {
 
 	private model: DirtyDiffModel | null = null;
 	private widget: DirtyDiffWidget | null = null;
-	// @ts-ignore unused property
-	private currentLineNumber: number = -1;
 	private currentIndex: number = -1;
 	private readonly isDirtyDiffVisible: IContextKey<boolean>;
 	private session: IDisposable = EmptyDisposable;
@@ -480,8 +475,6 @@ export class DirtyDiffController implements IEditorContribution {
 	constructor(
 		private editor: ICodeEditor,
 		@IContextKeyService contextKeyService: IContextKeyService,
-		// @ts-ignore unused injected service
-		@IThemeService private themeService: IThemeService,
 		@IInstantiationService private instantiationService: IInstantiationService
 	) {
 		this.enabled = !contextKeyService.getContextKeyValue('isInDiffEditor');
@@ -513,9 +506,6 @@ export class DirtyDiffController implements IEditorContribution {
 			this.currentIndex = rot(this.currentIndex + 1, this.model.changes.length);
 		}
 
-		const change = this.model.changes[this.currentIndex];
-		this.currentLineNumber = change.modifiedStartLineNumber;
-
 		this.widget.showChange(this.currentIndex);
 	}
 
@@ -530,9 +520,6 @@ export class DirtyDiffController implements IEditorContribution {
 			this.currentIndex = rot(this.currentIndex - 1, this.model.changes.length);
 		}
 
-		const change = this.model.changes[this.currentIndex];
-		this.currentLineNumber = change.modifiedStartLineNumber;
-
 		this.widget.showChange(this.currentIndex);
 	}
 
@@ -875,13 +862,7 @@ export class DirtyDiffModel {
 	constructor(
 		private _editorModel: IModel,
 		@ISCMService private scmService: ISCMService,
-		// @ts-ignore unused injected service
-		@IModelService private modelService: IModelService,
 		@IEditorWorkerService private editorWorkerService: IEditorWorkerService,
-		// @ts-ignore unused injected service
-		@IWorkbenchEditorService private editorService: IWorkbenchEditorService,
-		// @ts-ignore unused injected service
-		@IWorkspaceContextService private contextService: IWorkspaceContextService,
 		@ITextModelService private textModelResolverService: ITextModelService
 	) {
 		this.diffDelayer = new ThrottledDelayer<IChange[]>(200);
@@ -1024,12 +1005,8 @@ export class DirtyDiffWorkbenchController implements ext.IWorkbenchContribution,
 	private disposables: IDisposable[] = [];
 
 	constructor(
-		// @ts-ignore unused injected service
-		@IMessageService private messageService: IMessageService,
 		@IWorkbenchEditorService private editorService: IWorkbenchEditorService,
 		@IEditorGroupService editorGroupService: IEditorGroupService,
-		// @ts-ignore unused injected service
-		@IWorkspaceContextService private contextService: IWorkspaceContextService,
 		@IInstantiationService private instantiationService: IInstantiationService
 	) {
 		this.disposables.push(editorGroupService.onEditorsChanged(() => this.onEditorsChanged()));

src/vs/workbench/parts/scm/electron-browser/scmMenus.ts

@@ -28,8 +28,7 @@ export class SCMMenus implements IDisposable {
 	private disposables: IDisposable[] = [];
 
 	constructor(
-		// @ts-ignore unused property
-		private provider: ISCMProvider | undefined,
+		provider: ISCMProvider | undefined,
 		@IContextKeyService contextKeyService: IContextKeyService,
 		@IMenuService private menuService: IMenuService
 	) {

src/vs/workbench/parts/update/electron-browser/update.ts

@@ -128,8 +128,6 @@ export abstract class AbstractShowReleaseNotesAction extends Action {
 	constructor(
 		id: string,
 		label: string,
-		// @ts-ignore unused property
-		private returnValue: boolean,
 		private version: string,
 		@IWorkbenchEditorService private editorService: IWorkbenchEditorService,
 		@IInstantiationService private instantiationService: IInstantiationService
@@ -157,12 +155,11 @@ export abstract class AbstractShowReleaseNotesAction extends Action {
 export class ShowReleaseNotesAction extends AbstractShowReleaseNotesAction {
 
 	constructor(
-		returnValue: boolean,
 		version: string,
 		@IWorkbenchEditorService editorService: IWorkbenchEditorService,
 		@IInstantiationService instantiationService: IInstantiationService
 	) {
-		super('update.showReleaseNotes', nls.localize('releaseNotes', "Release Notes"), returnValue, version, editorService, instantiationService);
+		super('update.showReleaseNotes', nls.localize('releaseNotes', "Release Notes"), version, editorService, instantiationService);
 	}
 }
 
@@ -177,14 +174,13 @@ export class ShowCurrentReleaseNotesAction extends AbstractShowReleaseNotesActio
 		@IWorkbenchEditorService editorService: IWorkbenchEditorService,
 		@IInstantiationService instantiationService: IInstantiationService
 	) {
-		super(id, label, true, pkg.version, editorService, instantiationService);
+		super(id, label, pkg.version, editorService, instantiationService);
 	}
 }
 
 export class DownloadAction extends Action {
 
-	// @ts-ignore unused property
-	constructor(private url: string, @IUpdateService private updateService: IUpdateService) {
+	constructor( @IUpdateService private updateService: IUpdateService) {
 		super('update.download', nls.localize('downloadNow', "Download Now"), null, true);
 	}
 
@@ -303,8 +299,7 @@ class CommandAction extends Action {
 	constructor(
 		commandId: string,
 		label: string,
-		// @ts-ignore unused injected service
-		@ICommandService private commandService: ICommandService
+		@ICommandService commandService: ICommandService
 	) {
 		super(`command-action:${commandId}`, label, undefined, true, () => commandService.executeCommand(commandId));
 	}
@@ -397,10 +392,10 @@ export class UpdateContribution implements IGlobalActivity {
 	}
 
 	private showUpdateNotification(version: string): void {
-		const releaseNotesAction = this.instantiationService.createInstance(ShowReleaseNotesAction, false, version);
+		const releaseNotesAction = this.instantiationService.createInstance(ShowReleaseNotesAction, version);
 
 		if (isLinux) {
-			const downloadAction = this.instantiationService.createInstance(DownloadAction, version);
+			const downloadAction = this.instantiationService.createInstance(DownloadAction);
 
 			this.messageService.show(severity.Info, {
 				message: nls.localize('thereIsUpdateAvailable', "There is an available update."),