Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest storing source code in WSL2 when /mnt folder is opened #4454

Closed
aeschli opened this issue Feb 11, 2021 · 7 comments
Closed

Suggest storing source code in WSL2 when /mnt folder is opened #4454

aeschli opened this issue Feb 11, 2021 · 7 comments
Assignees
Labels
feature-request Request for new features or functionality on-testplan plan-item A plan item wsl Issue in vscode-remote WSL
Milestone

Comments

@aeschli
Copy link
Contributor

aeschli commented Feb 11, 2021

When using WSL 2 on the Windows file system mount we want to show a recommendation to recommend moving the project files to the Linux file system for optimal file system performance.

More information can be seen at https://docs.microsoft.com/en-us/windows/wsl/compare-versions#performance-across-os-file-systems

@aeschli aeschli self-assigned this Feb 11, 2021
@aeschli aeschli added the wsl Issue in vscode-remote WSL label Feb 11, 2021
@aeschli aeschli added this to the February 2021 milestone Feb 11, 2021
@aeschli
Copy link
Contributor Author

aeschli commented Feb 11, 2021

@bamurtaugh The current message is:
You're currently using WSL 2 on the Windows file system mount. If possible, move your project files to the Linux file system for optimal file system performance. with a link to https://docs.microsoft.com/en-us/windows/wsl/compare-versions#performance-across-os-file-systems

Feedback and improvements are welcome!

@aeschli aeschli closed this as completed Feb 11, 2021
@bamurtaugh
Copy link
Member

I like the prompt! For users who may not be aware of this issue, or who may not fully understand the difference in the file systems, I think the link to the doc will be really helpful.

I'm curious to see how people interact with the prompt, and also how many people get it in the first place (i.e. how prominent of an issue is this) and how many people continue getting it over time (i.e. do we see a decline over time if folks are now aware of the best practice/change their storage techniques?).

@aeschli
Copy link
Contributor Author

aeschli commented Feb 12, 2021

Right now, the message will show up as long as the user has pressed 'Do not show again'.

I made an update so that we also get telemetry when the dialog is not showing due to 'Do not show again'. That way we can measure if the non-performant usage of WSL1 resp WSL2 declines.

@bamurtaugh
Copy link
Member

I think that's a good addition too! I think the telemetry we have in place should now help us see if this prompt sparks user interest and affects behavior/helps their performance over time.

@PavelSosin-320
Copy link

@dbaeumer Think twice!
Cons of the Linux rootFS usage:

  1. Limited size. When it is full then expansion of RootFS esxt4 vhxd is a mess
  2. No automatic backup in Azure and other backup services - configuration is required. It likes to fail and hang OneDrive
  3. Export to tar and moving to the Cloud storage requires 10Gb local free space at least and may last a long time if the connection is not very fast.
  4. Reading from Linux RootFS to the Windows FS is not too fast too. It is slow.

@dbaeumer
Copy link
Member

dbaeumer commented Mar 1, 2021

I think you meant @aeschli.

@PavelSosin-320
Copy link

I mean the maintenance problems can overweight performance gains. Many maintenance functions executed on the Windows folders automatically don't cover Linux FS, starting from virus scan to automatic cloud backup. The rootFS is ext4, i.e. no remote FS access or sharing is possible. Is any IT automation possible? The decision to use this feature produces massive additional, unexpected IT workload from a developer.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality on-testplan plan-item A plan item wsl Issue in vscode-remote WSL
Projects
None yet
Development

No branches or pull requests

4 participants