-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Panel "check remote" keeps popping out and interrupting my work #1760
Comments
Not sure exactly what you're referring to. I assume you are seeing the "Reconnecting" dialog. Since your connection is unstable, we might lose the connection and have to set it up again. |
Can you share the log from the Remote-SSH extension after this happens? |
I just had it happen this morning, almost right away after I reloaded the window after reconnecting to the network, then again just as I was trying to gather your log. This is the text from the output window titled "Remote - SSH":
That was the output right after I saw the window appear the first time. As I was writing this, like I mentioned above, it appeared again. When I checked the Remote - SSH output after that, this was the only additional line:
Again, while writing this, it happened two more times and again all I see are blank lines added:
None of the other logs are getting updated (by looking at their timestamps), but if any of the others would be useful, let me know. |
@Tyriar any idea why this would happen when I set |
They're on Windows 7 so my guess is it's this problem microsoft/vscode#43169 |
I'm using Windows 10 1809 (OS Build 17763.805) currently, not 7. |
Oh OK, I saw this and assumed it was talking about Windows 7:
So it works on the initial connection and all reconnects from the same window fail? Or just some?
This is definitely on winpty so it could be microsoft/vscode#57803. @RobertBlackhart were you on v1.40.0 when seeing this? Does updating to 1.40.1 help? |
I'm not sure what you mean by "all reconnects from the same window fail". I haven't experienced a lot of reconnect failures that I would currently pin on VSCode. This symptoms of this bug don't seem to be related to reconnects. It seems to happen even without them. I just updated to 1.41.0 today so I will have to let you know how it goes. |
@Tyriar I mean the problem is, the terminal is never supposed to be shown to the user at all because I set that flag and never try to reveal it. |
As of version 1.41.0, this is still occurring for me. |
I don't have any good way to measure this, but I do feel like it hasn't been happening nearly as often as it was when I first started watching this thread. |
Yes, same as I met. |
I haven't seen this error in any recent times. Some update must have fixed it at or around 1.41.0. This issue can be closed. |
Thanks for following up! |
Hmm, bad news. I just saw this pop up again. I'm currently running this version:
|
Something new I've noticed. It used to be that the "Check Remote" window was blank. Now when it appears, it has the text "source <path_to_my_pyenv>" in it. Could this window be related to something in the Python extension? This text is not always present. Sometimes when the window appears it's still blank, but I've seen it more than once. |
Same |
Are you sure it's the terminal that says "check remote" and not a terminal related to the python extension? |
Can you share your settings? |
settings.json {
"git.enableSmartCommit": true,
"editor.cursorBlinking": "phase",
"editor.fontFamily": "'Cascadia Code', 'PingFang SC Regular'",
"editor.fontLigatures": true,
"editor.minimap.enabled": false,
"editor.mouseWheelZoom": true,
"editor.rulers": [
80,
100,
120
],
"zenMode.centerLayout": false,
"zenMode.hideTabs": false,
"explorer.confirmDelete": false,
"git.confirmSync": false,
"git.autofetch": true,
"workbench.iconTheme": "vscode-icons",
"terminal.integrated.shell.windows": "C:\\Windows\\System32\\WindowsPowerShell\\v1.0\\powershell.exe",
"workbench.startupEditor": "newUntitledFile",
"terminal.integrated.enableBell": true,
"remote.SSH.showLoginTerminal": true,
"remote.SSH.enableDynamicForwarding": true,
"remote.SSH.allowLocalServerDownload": true,
"editor.suggestSelection": "first",
"vsintellicode.modify.editor.suggestSelection": "automaticallyOverrodeDefaultValue",
"python.jediEnabled": false,
"files.exclude": {
"**/.classpath": true,
"**/.project": true,
"**/.settings": true,
"**/.factorypath": true
},
"files.autoGuessEncoding": false
} |
Does it still happen if you disable |
Here is my settings.json. I don't have the remote.SSH.showLoginTerminal set. I think the default is false though (because that's what the editor fills in for me when I put that key name in). I will set it to false explicitly and see what happens.
|
The problem appeared to me this morning, whereas I have been working in remote SSH for weeks now (and on the same remote computer). Maybe a new version of the Python extension has made it appear? Anyway the above fix worked on the remote version of the extension. My VSCode info : Version: 1.46.1 My local OS is macOS 10.13.6 and my remote OS is Linux x64 4.15.0-1065-aws. I have the Python extension v2020.6.90262 installed on both. |
still... |
This works as an interim solution for me. |
The same here. It looks like that vscode terminal automatically activating python envs will spawn it. |
Thanks! |
Is there any workarounds without setting python.terminal.activateEnvironment to false? |
Having the same issue here on VSCode 1.47.0 |
same here, newest osx on host accessing ubuntu 1804 remote and using conda as env manager. |
Having the same issue here. |
The Python team has released a fix in the latest build of the extension. Could someone check that you are on at least |
I am on VSCode |
Same experience as @brbecker. I'm on the latest version, and when I have |
I have a similar issue on VSCode 1.47.2 with an OSX Host, Ubuntu 18.04 remote. 2020.7.96456 python extension. Edit: actually, it just asked me to reload vscode -- that's the python extension version it just installed, not sure what the old version was anymore. We'll see if this goes away.... |
We can confirm it's not been fixed yet. We have identified the issue and will be releasing the fix soon. Thanks for cooperating. |
This should be fixed with the latest VS Code Insiders https://code.visualstudio.com/insiders and the latest version of the Python extension. Can anyone confirm? |
I can confirm I no longer see the issue. |
@roblourens when would this be merged with the non-insiders version? |
This week - Wednesday or Thursday. |
Steps to Reproduce:
Does this issue occur when you try this locally?: No
Does this issue occur when you try this locally and all extensions are disabled?: No
The text was updated successfully, but these errors were encountered: