Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support settings property in attached config files #1589

Closed
Chuxel opened this issue Oct 2, 2019 · 0 comments
Closed

Support settings property in attached config files #1589

Chuxel opened this issue Oct 2, 2019 · 0 comments
Assignees
Labels
containers Issue in vscode-remote containers plan-item A plan item
Milestone

Comments

@Chuxel
Copy link
Member

Chuxel commented Oct 2, 2019

Related to #1513

The new attached configuration files currently appear to support two properties: workspaceFolder and extensions.

Given user settings often are not correct for extensions in a container environment (as highlighted by the number of devcontainer.json files with at least one setting), it seems highly likely that customers are going to want to be able to update container specific config as well from these files.

@chrmarti chrmarti added containers Issue in vscode-remote containers feature-request Request for new features or functionality labels Oct 3, 2019
@chrmarti chrmarti added this to the November 2019 milestone Nov 6, 2019
@chrmarti chrmarti added plan-item A plan item and removed feature-request Request for new features or functionality labels Nov 6, 2019
@chrmarti chrmarti closed this as completed Nov 6, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
containers Issue in vscode-remote containers plan-item A plan item
Projects
None yet
Development

No branches or pull requests

2 participants