Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrapbook media types emit warning in notebook executions #2374

Closed
MSeal opened this issue Jan 28, 2020 · 4 comments
Closed

Scrapbook media types emit warning in notebook executions #2374

MSeal opened this issue Jan 28, 2020 · 4 comments
Assignees

Comments

@MSeal
Copy link

MSeal commented Jan 28, 2020

Bug: Notebook Editor, Interactive Window, Editor cells

Steps to cause the bug to occur

  1. Install scrapbook pip install nteract-scrapbook
  2. Create and execute this cell
import scrapbook as sb
sb.glue("hello", "world")

Actual behavior

Note the warning messages for the unrecognized mime type

"The Mime type unknown is not currently supported."

Expected behavior

Silently skip rendering application/scrapbook.scrap.{encoder}+json as it doesn't need a rendering. And example output would be:

     "data": {
      "application/scrapbook.scrap.json+json": {
       "data": {
        "a": 1,
        "b": 2
       },
       "encoder": "json",
       "name": "some_dict",
       "version": 1
      }

In the future there may be extra prefixes to the mimetypes like application/scrapbook.scrap.{future_prefixes_here}.{encoder}+json

See: nteract/scrapbook#69

Your Jupyter and/or Python environment

Please provide as much info as you readily know

  • Jupyter server running: Local / N/A
  • Extension version: 2020.1.58038
  • VS Code version: 1.41.1
  • Setting python.jediEnabled: false
  • Python and/or Anaconda version: 3.x.x
  • OS: Linux (Ubuntu 18.04) / N/A:
  • Virtual environment: N/A

Developer Tools Console Output

Microsoft Data Science for VS Code Engineering Team: @rchiodo, @IanMatthewHuff, @DavidKutu, @DonJayamanne, @greazer

@IanMatthewHuff
Copy link
Member

Thanks for the report on this. I can see an issue here as well, though I'm seeing a slightly more concerning error message (might just be our dev build). We'll look into it:

@IanMatthewHuff
Copy link
Member

Just for tracking, when I input this it blows the cell away totally:
image

@greazer
Copy link
Member

greazer commented Jan 30, 2020

We can't crash if we run across an unknown mime type.

@DavidKutu DavidKutu self-assigned this Feb 4, 2020
@IanMatthewHuff IanMatthewHuff self-assigned this Feb 6, 2020
@IanMatthewHuff
Copy link
Member

Validated on most recent VSIX from release CI. Nothing in the output now as it's just skipped.

@lock lock bot locked as resolved and limited conversation to collaborators Feb 13, 2020
@microsoft microsoft unlocked this conversation Nov 13, 2020
@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-python Nov 13, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants