-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Saving .py files delayed by "Getting code actions from 'isort', 'Python', 'Jupyter'" #19808
Comments
Switching to the pre-release (v2022.15.12511012) of the Python extension seems like it might have fixed it for me... I'll reply again if it happens again. |
@alexkyllo Do you have the isort extension installed? if you do, please share the logs from Output > isort. Also, I recommend using black formatter extension and pylint extension. You should disable formatting ( |
Hi @karthiknadig, Yes I do have the isort extension installed. It looks like there are some KeyErrors for '.' and '/'. Outputs below--but I'm not sure when they're from since they aren't timestamped. I did as you said and disabled formatting/linting from the Python extension and enabled them from the dedicated isort, black, and pylint extensions instead. No issues at the moment.
|
@alexkyllo I created an issue in vscode-isort to track the KeyError |
Do let us know if the Code Action issue occurs again. |
Because we have not heard back with the information we requested, we are closing this issue for now. If you are able to provide the info later on, then we will be happy to re-open this issue to pick up where we left off. |
@alexkyllo Can you share what you have in Output > isort logs? |
I'm so sorry, I had to reload my VS Code window for another reason and that made the hangs stop happening, and that also cleared the output logs. I guess I'll keep an eye on it and post the logs here if it happens again... |
Hi, facing same probleme here : this lasted 4 or 5 minutes. In output/isort logs, nothing relevant :
|
If people are not using Jupyter or isort can they try disabling one of them and seeing if it still happens? |
I was getting a similar pop. The list of extensions I had was 'isort', 'Jupyter', 'Sourcery' disabling Jupyter fixed it. So it seems to be an issue with that extension. |
I take it back, it seems to only temporarily relieve the issue. It is now still hanging on 'Getting code actions from ''isort, Sourcery'' |
I think disabling isort helped a little...it's hard to tell because it does seem a bit random. I reenabled isort because we do use the plugin. Just sat through about a 20 seconds of " Getting code actions from ''Sourcery', 'isort'' " |
In microsoft/vscode-isort#175, @willjhenry found out it was due to Sourcery. |
It seems to have gone away - maybe the latest vs code update? I now have Sourcery and isort active and I have not seen the popup in a few days. I used to see it every ~3rd save. |
and I think maybe it wasn't due to Sourcery.. maybe it was an interaction between vs code and Sourcery, idk. |
I don't we consider this fixed, but if it comes up again then let us know and we can reopen this issue. |
Type: Performance Issue
Behaviour
Whenever I save a .py file, I see a message in the lower right notification box:
Saving 'main.py': Getting code actions from ''isort', 'Python', 'Jupyter''.
It hangs long enough (several minutes) that I have to cancel it and it happens every time I try to save. I first noticed it yesterday.
Expected vs. Actual
Saving .py files (and applying code actions) used to take an imperceptibly short amount of time, now it takes a very long time.
Steps to reproduce:
Diagnostic data
python.languageServer
setting: PylanceOutput for
Python
in theOutput
panel (View
→Output
, change the drop-down the upper-right of theOutput
panel toPython
)User Settings
Extension version: 2022.15.12511012
VS Code version: Code - Insiders 1.72.0-insider (0f2de31e4856886cdbf32f85488bc40f480fb38f, 2022-09-07T05:17:13.628Z)
OS version: Windows_NT x64 10.0.22000
Modes:
Sandboxed: Yes
Remote OS version: Linux x64 5.10.102.1-microsoft-standard-WSL2
System Info
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: disabled_off
Process Info
Workspace Info
A/B Experiments
The text was updated successfully, but these errors were encountered: