Add linting check and fix linting issues (#30)

Author: karthiknadig

.github/workflows/pr-check.yml

@@ -8,8 +8,7 @@ on:
       - release*
 
 env:
-  NODE_VERSION: 18.17.1
-
+  NODE_VERSION: '20.18.0'
 
 jobs:
   build-vsix:
@@ -24,3 +23,53 @@ jobs:
         uses: ./.github/actions/build-vsix
         with:
           node_version: ${{ env.NODE_VERSION }}
+
+  lint:
+    name: Lint
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Install Node
+        uses: actions/setup-node@v4
+        with:
+          node-version: ${{ env.NODE_VERSION }}
+          cache: 'npm'
+
+      - name: Install Dependencies
+        run: npm ci
+
+      - name: Run Linter
+        run: npm run lint
+
+  ts-unit-tests:
+    name: TypeScript Unit Tests
+    runs-on: ${{ matrix.os }}
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [ubuntu-latest, windows-latest]
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Install Node
+        uses: actions/setup-node@v4
+        with:
+          node-version: ${{ env.NODE_VERSION }}
+          cache: 'npm'
+
+      - name: Install Dependencies
+        run: npm ci
+
+      - name: Compile Tests
+        run: npm run pretest
+
+      - name: Localization
+        run: npx @vscode/l10n-dev@latest export ./src
+
+      - name: Run Tests
+        run: npm run unittest

.github/workflows/push-check.yml

@@ -9,7 +9,7 @@ on:
       - 'release-*'
 
 env:
-  NODE_VERSION: 18.17.1
+  NODE_VERSION: '20.18.0'
 
 jobs:
   build-vsix:
@@ -23,4 +23,54 @@ jobs:
       - name: Build VSIX
         uses: ./.github/actions/build-vsix
         with:
-          node_version: ${{ env.NODE_VERSION }}
+          node_version: ${{ env.NODE_VERSION }}
+
+  lint:
+    name: Lint
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Install Node
+        uses: actions/setup-node@v4
+        with:
+          node-version: ${{ env.NODE_VERSION }}
+          cache: 'npm'
+
+      - name: Install Dependencies
+        run: npm ci
+
+      - name: Run Linter
+        run: npm run lint
+
+  ts-unit-tests:
+    name: TypeScript Unit Tests
+    runs-on: ${{ matrix.os }}
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [ubuntu-latest, windows-latest]
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Install Node
+        uses: actions/setup-node@v4
+        with:
+          node-version: ${{ env.NODE_VERSION }}
+          cache: 'npm'
+
+      - name: Install Dependencies
+        run: npm ci
+
+      - name: Compile Tests
+        run: npm run pretest
+
+      - name: Localization
+        run: npx @vscode/l10n-dev@latest export ./src
+
+      - name: Run Tests
+        run: npm run unittest

.vscode/launch.json

@@ -16,7 +16,7 @@
         {
             "args": [
                 "-u=tdd",
-                "--timeout=999999",
+                "--timeout=180000",
                 "--colors",
                 "--recursive",
                 //"--grep", "<suite name>",

.vscode/settings.json

@@ -14,5 +14,9 @@
     "[typescript]": {
         "editor.defaultFormatter": "esbenp.prettier-vscode"
     },
+    "[python]": {
+        "editor.defaultFormatter": "charliermarsh.ruff",
+        "diffEditor.ignoreTrimWhitespace": false
+    },
     "prettier.tabWidth": 4
 }

build/.mocha.unittests.json

@@ -0,0 +1,8 @@
+{
+    "spec": "./out/test/**/*.unit.test.js",
+    "require": ["out/test/unittests.js"],
+    "ui": "tdd",
+    "recursive": true,
+    "colors": true,
+    "timeout": 180000
+}

eslint.config.mjs

@@ -19,10 +19,22 @@ export default [{
             selector: "import",
             format: ["camelCase", "PascalCase"],
         }],
-
+        "@typescript-eslint/no-unused-vars": [
+                "error",
+                {
+                  "args": "all",
+                  "argsIgnorePattern": "^_",
+                  "caughtErrors": "all",
+                  "caughtErrorsIgnorePattern": "^_",
+                  "destructuredArrayIgnorePattern": "^_",
+                  "varsIgnorePattern": "^_",
+                  "ignoreRestSiblings": true
+                }
+              ],
         curly: "warn",
         eqeqeq: "warn",
         "no-throw-literal": "warn",
         semi: "warn",
+        "@typescript-eslint/no-explicit-any": "warn",
     },
 }];