Skip to content

Commit e78a55a

Browse files
committed
fix: tweaks to messaging in logs
1 parent 7d4d384 commit e78a55a

File tree

1 file changed

+15
-5
lines changed

1 file changed

+15
-5
lines changed

src/features/common/managerReady.ts

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -64,18 +64,18 @@ class ManagerReadyImpl implements ManagerReady {
6464
if (installed) {
6565
const ext = getExtension(extId);
6666
if (ext && !ext.isActive) {
67-
traceInfo(`Extension for manager ${extId} is not active: Activating...`);
67+
traceInfo(`Extension for manager ${managerId} is not active: Activating...`);
6868
try {
6969
await ext.activate();
70-
traceInfo(`Extension for manager ${extId} is now active.`);
70+
traceInfo(`Extension for manager ${managerId} is now active.`);
7171
} catch (err) {
7272
traceError(`Failed to activate extension ${extId}, required for: ${managerId}`, err);
7373
}
7474
}
7575
} else {
76-
traceError(`Extension for manager ${extId} is not installed.`);
76+
traceError(`Extension for manager ${managerId} is not installed.`);
7777
const result = await showErrorMessage(
78-
l10n.t(`Do you want to install extension ${extId} to enable {1} support.`, extId, managerId),
78+
l10n.t(`Do you want to install extension {0} to enable {1} support.`, extId, managerId),
7979
WorkbenchStrings.installExtension,
8080
);
8181
if (result === WorkbenchStrings.installExtension) {
@@ -84,7 +84,17 @@ class ManagerReadyImpl implements ManagerReady {
8484
await installExtension(extId);
8585
traceInfo(`Extension ${extId} installed.`);
8686
} catch (err) {
87-
traceError(`Failed to install extension: ${extId}`, err);
87+
traceError(`Failed to install extension: ${extId}`, err);
88+
}
89+
90+
try {
91+
const ext = getExtension(extId);
92+
if (ext && !ext.isActive) {
93+
traceInfo(`Extension for manager ${managerId} is not active: Activating...`);
94+
await ext.activate();
95+
}
96+
} catch (err) {
97+
traceError(`Failed to activate extension ${extId}, required for: ${managerId}`, err);
8898
}
8999
}
90100
}

0 commit comments

Comments
 (0)