Ensure venv creation and packages checks for python2 before attempting creation or package operations (#66)

Closes #67

Author: karthiknadig

src/api.ts

@@ -193,10 +193,9 @@ export interface PythonEnvironmentInfo {
     readonly iconPath?: IconPath;
 
     /**
-     * Information on how to execute the Python environment. If not provided, {@link PythonEnvironmentApi.resolveEnvironment} will be
-     * used to to get the details at later point if needed. The recommendation is to fill this in if known.
+     * Information on how to execute the Python environment. This is required for executing Python code in the environment.
      */
-    readonly execInfo?: PythonEnvironmentExecutionInfo;
+    readonly execInfo: PythonEnvironmentExecutionInfo;
 
     /**
      * `sys.prefix` is the path to the base directory of the Python installation. Typically obtained by executing `sys.prefix` in the Python interpreter.

src/features/pythonApi.ts

@@ -116,6 +116,7 @@ class PythonEnvironmentApiImpl implements PythonEnvironmentApi {
         };
         return new PythonEnvironmentImpl(envId, info);
     }
+
     async createEnvironment(scope: CreateEnvironmentScope): Promise<PythonEnvironment | undefined> {
         if (scope === 'global' || (!Array.isArray(scope) && scope instanceof Uri)) {
             const manager = this.envManagers.getEnvironmentManager(scope === 'global' ? undefined : scope);

src/internal.api.ts

@@ -266,7 +266,7 @@ export class PythonEnvironmentImpl implements PythonEnvironment {
     public readonly description?: string;
     public readonly tooltip?: string | MarkdownString;
     public readonly iconPath?: IconPath;
-    public readonly execInfo?: PythonEnvironmentExecutionInfo;
+    public readonly execInfo: PythonEnvironmentExecutionInfo;
     public readonly sysPrefix: string;
 
     constructor(public readonly envId: PythonEnvironmentId, info: PythonEnvironmentInfo) {

src/managers/sysPython/utils.ts

@@ -313,6 +313,10 @@ export async function installPackages(
     api: PythonEnvironmentApi,
     manager: PackageManager,
 ): Promise<Package[]> {
+    if (environment.version.startsWith('2.')) {
+        throw new Error('Python 2.* is not supported (deprecated)');
+    }
+
     if (environment.execInfo) {
         if (packages.length === 0) {
             throw new Error('No packages selected to install');
@@ -350,6 +354,10 @@ export async function uninstallPackages(
     manager: PackageManager,
     packages: string[] | Package[],
 ): Promise<Package[]> {
+    if (environment.version.startsWith('2.')) {
+        throw new Error('Python 2.* is not supported (deprecated)');
+    }
+
     if (environment.execInfo) {
         const remove = [];
         for (let pkg of packages) {

src/managers/sysPython/venvUtils.ts

@@ -254,20 +254,35 @@ export async function createPythonVenv(
     basePythons: PythonEnvironment[],
     venvRoot: Uri,
 ): Promise<PythonEnvironment | undefined> {
-    const filtered = basePythons.filter((e) => e.execInfo);
-    if (filtered.length === 0) {
+    if (basePythons.length === 0) {
         log.error('No base python found');
         showErrorMessage('No base python found');
         return;
     }
 
+    const filtered = basePythons.filter((e) => e.version.startsWith('3.'));
+    if (filtered.length === 0) {
+        log.error('Did not find any base python 3.*');
+        showErrorMessage('Did not find any base python 3.*');
+        basePythons.forEach((e) => {
+            log.error(`available base python: ${e.version}`);
+        });
+        return;
+    }
+
     const basePython = await pickEnvironmentFrom(sortEnvironments(filtered));
     if (!basePython || !basePython.execInfo) {
         log.error('No base python selected, cannot create virtual environment.');
         showErrorMessage('No base python selected, cannot create virtual environment.');
         return;
     }
 
+    if (basePython.version.startsWith('2.')) {
+        log.error('Python 2.* is not supported for virtual env creation');
+        showErrorMessage('Python 2.* is not supported, use Python 3.*');
+        return;
+    }
+
     const name = await showInputBox({
         prompt: 'Enter name for virtual environment',
         value: '.venv',