Skip to content

Add auto start browser as default value #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 23, 2024
Merged

Add auto start browser as default value #229

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8cc6e3e
Add autoStartBrowser
paulacamargo25 Feb 22, 2024
a0e3e04
fix tests
paulacamargo25 Feb 22, 2024
48c916a
fix lint
paulacamargo25 Feb 22, 2024
bc64972
fix tests
paulacamargo25 Feb 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/extension/debugger/configuration/providers/djangoLaunch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ export async function buildDjangoLaunchDebugConfiguration(
program: program || defaultProgram,
args: ['runserver'],
django: true,
autoStartBrowser: false,
};
if (!program) {
const selectedProgram = await input.showInputBox({
Expand Down
1 change: 1 addition & 0 deletions src/extension/debugger/configuration/providers/flaskLaunch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ export async function buildFlaskLaunchDebugConfiguration(
},
args: ['run', '--no-debugger', '--no-reload'],
jinja: true,
autoStartBrowser: false,
};

if (!application) {
Expand Down
2 changes: 2 additions & 0 deletions src/test/unittest/configuration/providers/djangoLaunch.unit.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ suite('Debugging - Configuration Provider Django', () => {
program: 'hello',
args: ['runserver'],
django: true,
autoStartBrowser: false,
};

expect(state.config).to.be.deep.equal(config);
Expand All @@ -129,6 +130,7 @@ suite('Debugging - Configuration Provider Django', () => {
program: defaultProgram,
args: ['runserver'],
django: true,
autoStartBrowser: false,
};

expect(state.config).to.be.deep.equal(config);
Expand Down
24 changes: 24 additions & 0 deletions src/test/unittest/configuration/providers/flaskLaunch.unit.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,28 @@ suite('Debugging - Configuration Provider Flask', () => {

expect(file).to.be.equal('app.py');
});
test('Launch JSON with valid python path', async () => {
const folder = { uri: Uri.parse(path.join('one', 'two')), name: '1', index: 0 };
const state = { config: {}, folder };

await flaskLaunch.buildFlaskLaunchDebugConfiguration(instance(input), state);

const config = {
name: DebugConfigStrings.flask.snippet.name,
type: DebuggerTypeName,
request: 'launch',
module: 'flask',
env: {
FLASK_APP: 'app.py',
FLASK_DEBUG: '1',
},
args: ['run', '--no-debugger', '--no-reload'],
jinja: true,
autoStartBrowser: false,
};

expect(state.config).to.be.deep.equal(config);
});
test('Launch JSON with selected app path', async () => {
const folder = { uri: Uri.parse(path.join('one', 'two')), name: '1', index: 0 };
const state = { config: {}, folder };
Expand All @@ -60,6 +82,7 @@ suite('Debugging - Configuration Provider Flask', () => {
},
args: ['run', '--no-debugger', '--no-reload'],
jinja: true,
autoStartBrowser: false,
};

expect(state.config).to.be.deep.equal(config);
Expand All @@ -82,6 +105,7 @@ suite('Debugging - Configuration Provider Flask', () => {
},
args: ['run', '--no-debugger', '--no-reload'],
jinja: true,
autoStartBrowser: false,
};

expect(state.config).to.be.deep.equal(config);
Expand Down