Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test localization #4103

Closed
2 tasks done
alexr00 opened this issue Oct 24, 2022 · 6 comments
Closed
2 tasks done

Test localization #4103

alexr00 opened this issue Oct 24, 2022 · 6 comments

Comments

@alexr00
Copy link
Member

alexr00 commented Oct 24, 2022

Refs: #3913

Complexity: 1

Create Issue


  1. Install the pre-release build of the extension
  2. Set your VS Code display language to something other than English (if you don't already have a language pack installed, you'll need to do so).
  3. Verify that strings that come from this extension (but not the extension's webviews) are localized. Some ideas for strings to check: status bar entries, view titles, welcome view content, command titles.
@alexr00 alexr00 added this to the October 2022 milestone Oct 24, 2022
@TylerLeonhardt
Copy link
Member

It would be worthwhile to test this on both Desktop & Web since it should work in both places now. FYI @joaomoreno

@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented Oct 25, 2022

@alexr00 I have opened #4107 to add more strings that I noticed weren't being localized. With that said, this appears to be working for the strings that are localized.

@TylerLeonhardt TylerLeonhardt removed their assignment Oct 25, 2022
@joaomoreno
Copy link
Member

@alexr00 I have opened #4107 to add more strings that I noticed weren't being localized. With that said, this appears to be working for the strings that are localized.

I have added more changes to that PR.

@joaomoreno
Copy link
Member

Tested both https://insiders.vscode.dev as well as Windows x64 desktop.

@joaomoreno
Copy link
Member

@TylerLeonhardt, @rzhao271, I noticed some extensions have their names translated in the Settings view. What's your preference here?

image

The extension itself is translated in some places:

image

But not others:

image

@joaomoreno joaomoreno removed their assignment Oct 25, 2022
@rzhao271
Copy link
Contributor

I don't mind more of the program being translated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants