Skip to content

Cancel query button is always enabled #1584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Charles-Gagnon opened this issue Jan 31, 2020 · 4 comments · Fixed by #17141
Closed

Cancel query button is always enabled #1584

Charles-Gagnon opened this issue Jan 31, 2020 · 4 comments · Fixed by #17141

Comments

@Charles-Gagnon
Copy link
Contributor

This should be disabled when a query isn't currently running

image

Clicking on it results in this error

mssql: Cannot cancel query as no query is running.

@abist
Copy link
Contributor

abist commented Feb 20, 2020

Since this command is contributed from the package.json file, there's no way to show it as "disabled". I can, however, change when it appears on the editor. Would it be better to only show the Cancel Query icon if there's a query running?

@Charles-Gagnon
Copy link
Contributor Author

Couldn't you have the run button switch to cancel when it's running?

@abist
Copy link
Contributor

abist commented Feb 22, 2020

@Charles-Gagnon If we are fine with that UX, we can do that. @yualan thoughts?

@abist abist mentioned this issue Feb 25, 2020
4 tasks
@xsoheilalizadeh
Copy link

@Charles-Gagnon's suggestion has good UX, I would like to work on it. This could implement by changing the command icon in runtime, as I investigated for this change we can't do this at this time (I'm not sure), therefore I asked @jrieken, he said they are already working on it for May iteration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants