New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mock debug adapter sends stop event before response to step request in violation of the spec #91

Open

FeldrinH opened this issue Feb 26, 2023 · 0 comments

FeldrinH commented Feb 26, 2023

The DAP specification (https://microsoft.github.io/debug-adapter-protocol/specification#Requests_Next) states the following about all the step requests (next, stepIn, stepOut, stepBack):

The debug adapter first sends the response and then a stopped event (with reason step) after the step has completed.

The mock debug adapter appears to do this in reverse, violating the spec.
Looking at https://github.com/microsoft/vscode-mock-debug/blob/main/src/mockDebug.ts#L511-L539, it appears that the runtime step method (which indirectly, but as far as I can tell synchronously, sends the stop event) is called before sending a response to the step request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment