Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TagSupport for Diagnostics should be included in the docs #477

Closed
tinaschrepfer opened this issue Apr 9, 2019 · 3 comments
Closed

TagSupport for Diagnostics should be included in the docs #477

tinaschrepfer opened this issue Apr 9, 2019 · 3 comments

Comments

@tinaschrepfer
Copy link
Member

Looks like TagSupport and DiagnosticTag are in the protocol source code, but not included in the documentation (https://microsoft.github.io/language-server-protocol/specification). Should add it to specification so they're easier to search for.
@rcjsuen
Copy link
Contributor

rcjsuen commented Apr 9, 2019

Great catch, @tinaschrepfer. Looks like it was added in 16c0eac. I'll bring this up in microsoft/language-server-protocol#500.

@rcjsuen rcjsuen mentioned this issue Apr 9, 2019
Closed
@dbaeumer
Copy link
Member

The reason why this is not in the spec yet is that it is only in 3.15.0-next.x version of the protocol which is not final.

@dbaeumer dbaeumer added this to the On Deck milestone Apr 10, 2019
@dbaeumer
Copy link
Member

This is in the next version.

https://microsoft.github.io/language-server-protocol/specifications/specification-3-15/#diagnostic

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 8, 2019
@dbaeumer dbaeumer removed this from the On Deck milestone Dec 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dbaeumer @tinaschrepfer @rcjsuen