-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt to new vscode log output channel API #1116
Comments
I recalled all the discussion we had and I looked into making this backwards compatible with the settings I introduced. However this is quite some work for no real benefit. So I decided to make this a breaking change to align with VS Code's behavior and ship it in 3.18. |
@dbaeumer following up on this, are there any major issues pending or anything I can contribute (tests, etc.) to move this along? For the |
Alternatively, have you considered implementing something like the DebugAdapterTrackerFactory in vscode? As an author, I find this the most useful as I can control how messages from the client are logged. |
You can do that in LSP as well. It provides a middleware were you can intercept each message in a specific or generic way. |
https://github.com/microsoft/vscode/blob/ed1bc56bd8b6343296ba8310167928e1e955a74e/src/vscode-dts/vscode.proposed.extensionLog.d.ts#L1
The text was updated successfully, but these errors were encountered: