Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt to new vscode log output channel API #1116

Open
sandy081 opened this issue Nov 8, 2022 · 5 comments
Open

Adopt to new vscode log output channel API #1116

sandy081 opened this issue Nov 8, 2022 · 5 comments
Assignees
Labels
feature-request Request for new features or functionality
Milestone

Comments

@dbaeumer dbaeumer added this to the Next milestone Dec 9, 2022
@dbaeumer
Copy link
Member

See https://github.com/microsoft/vscode-languageserver-node/tree/dbaeumer/adaptLogChannel

@dbaeumer
Copy link
Member

I recalled all the discussion we had and I looked into making this backwards compatible with the settings I introduced. However this is quite some work for no real benefit. So I decided to make this a breaking change to align with VS Code's behavior and ship it in 3.18.

@dbaeumer dbaeumer modified the milestones: Next, 3.18 Sep 13, 2023
@dbaeumer dbaeumer added feature-request Request for new features or functionality and removed feature request labels Nov 17, 2023
@dbaeumer dbaeumer modified the milestones: 3.18, On Deck Jul 8, 2024
@JustinGrote
Copy link

@dbaeumer following up on this, are there any major issues pending or anything I can contribute (tests, etc.) to move this along? For the PowerShell extension we really would like our LSP server messages to have severity filtering available.

@JustinGrote
Copy link

Alternatively, have you considered implementing something like the DebugAdapterTrackerFactory in vscode?
https://vscode-api.js.org/interfaces/vscode.DebugAdapterTrackerFactory.html

As an author, I find this the most useful as I can control how messages from the client are logged.

@dbaeumer
Copy link
Member

You can do that in LSP as well. It provides a middleware were you can intercept each message in a specific or generic way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

3 participants