Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebooks - Kernel Not Saved #9512

Closed
claudiaregio opened this issue Jan 28, 2022 · 6 comments
Closed

Notebooks - Kernel Not Saved #9512

claudiaregio opened this issue Jan 28, 2022 · 6 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug notebook-serialization Applies to conversion of ipynb file to JSON & vice versa papercut 🩸 Something affecting the productivity of the team upstream-vscode Blocked on upstream VS code verification-needed Verification of issue is requested

Comments

@claudiaregio
Copy link
Contributor

  • VS Code Version: 1.63.2
  • OS Version: Windows 11

Steps to Reproduce:

  1. Create notebook
  2. Select kernel and write code/run cells
  3. Save notebook
  4. Kernel selection disappears

I started working on an analysis and when I got to a checkpoint I was happy with I saved the notebook. After saving I tried to keep working and started getting errors in my notebook and it took me a few minutes to realize the kernel was not saved so I had to select it again and rerun everything to get back to where I was, a pretty annoying papercut

@claudiaregio claudiaregio added the papercut 🩸 Something affecting the productivity of the team label Jan 28, 2022
@greazer greazer added nb-golden bug Issue identified by VS Code Team member as probable bug notebook-serialization Applies to conversion of ipynb file to JSON & vice versa labels Jan 28, 2022
@rebornix rebornix assigned roblourens and unassigned rebornix Feb 4, 2022
@roblourens
Copy link
Member

Is there already an issue for this? We've discussed this but I can't find it. Need to figure out how to transfer a kernel registration from an untitled document to another one which we don't have a straightforward way to do.

@claudiaregio
Copy link
Contributor Author

I could have sworn I had opened this issue in the past but could not find it for the life of me so I just filed it again😆

@claudiaregio
Copy link
Contributor Author

Any chance there is an update on this?

@rebornix
Copy link
Member

When the untitled notebook is saved, the kernel and language info are saved to disk but the Jupyter extension won't use the previously selected kernel as preferred kernel. Though if you create an untitled notebook again, you will get the same kernel.

@DonJayamanne
Copy link
Contributor

As discussed, labelling as upstream vscode, as the kernel selection is maintained in vscode core and the selected kernel needs to be transitioned upon saving as another file.

@DonJayamanne
Copy link
Contributor

This should be fixed now, closing this for verification

@DonJayamanne DonJayamanne added the verification-needed Verification of issue is requested label Dec 4, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug notebook-serialization Applies to conversion of ipynb file to JSON & vice versa papercut 🩸 Something affecting the productivity of the team upstream-vscode Blocked on upstream VS code verification-needed Verification of issue is requested
Projects
None yet
Development

No branches or pull requests

7 participants
@roblourens @rebornix @DonJayamanne @greazer @claudiaregio @rchiodo and others