Lost text focus after "Ctrl-Enter" is pressed on jupyter notebook

[ws1088]

Environment data

• VS Code version: 1.57
• Jupyter Extension version (available under the Extensions sidebar): v2021.6.999406279
• Python Extension version (available under the Extensions sidebar): v2021.6.944021595
• OS (Windows | Mac | Linux distro) and version: Windows 10, Mac, and Linux
• Python and/or Anaconda version: 3.7.4
• Type of virtual environment used (N/A | venv | virtualenv | conda | ...): virtualenv
• Jupyter server running: Local and Remote

Expected behaviour

Should be like previous versions (before 1.57.0), when pressing "Ctrl-Enter" to run a cell, the text focus should remain in that some cell's text area, getting ready for users to add/change code and rerun.

Actual behaviour

Focus is lost

Steps to reproduce:

1. open a jupyter notebook
2. type print(1)
3. press "Ctrl-Enter" to run the cell

[joyceerhl]

@ws1088 The previous behavior where focus remains in the text editor after ctrl+enter was actually a bug, as reported by another user: #6198 We fixed this by contributing ctrl+enter tied to a custom command, jupyter.notebookeditor.keybind.executeCell.

You can go back to the old ctrl+enter behavior by opening the keyboard shortcuts configuration page:

And changing the keybinding for the following command to anything else:

[ws1088]

thanks. it's interesting how different use cases consider something as a bug or not. personally i like ctrl-enter to remains in the cell focus because most of the time i would write some code and test it out. maybe 5% of the time when i press ctrl-enter i would want to loose focus.
I ended up removing jupyter.notebookeditor.keybind.executeCell and added back notebook.cell.execute to get back to pre-1.57.0 behavior:

    {
        "key": "ctrl+enter",
        "command": "-jupyter.notebookeditor.keybind.executeCell",
        "when": "config.jupyter.enableKeyboardShortcuts && notebookCellListFocused && notebookCellType == 'code' && notebookType == 'jupyter-notebook' || config.jupyter.enableKeyboardShortcuts && editorTextFocus && inputFocus && notebookEditorFocused && notebookType == 'jupyter-notebook'"
    },
    {
        "key": "ctrl+enter",
        "command": "notebook.cell.execute",
        "when": "notebookCellListFocused && notebookCellType == 'code' && notebookCellExecutionState == 'failed' || notebookCellExecutionState == 'idle' || notebookCellExecutionState == 'succeeded' && notebookKernelCount > 0"
    },