Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new VSC API to trust output #4122

Closed
DonJayamanne opened this issue Dec 4, 2020 · 3 comments
Closed

Use the new VSC API to trust output #4122

DonJayamanne opened this issue Dec 4, 2020 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug upstream-vscode Blocked on upstream VS code

Comments

@DonJayamanne
Copy link
Contributor

DonJayamanne commented Dec 4, 2020

See here microsoft/vscode#108946 (comment) & microsoft/vscode#109104

We must change the existing code to use the new VSC API, as current approach is very hacky
(when we trust a notebook, we perform an edit and prevent VSCode from seeing it as a dirty change & force it to reload the notebook).
Hopefully with the new VSC API - all we need to do is just update a single property

@DonJayamanne DonJayamanne added the bug Issue identified by VS Code Team member as probable bug label Dec 4, 2020
@DonJayamanne
Copy link
Contributor Author

Block due to microsoft/vscode#114936

@kieferrm
Copy link
Member

kieferrm commented Mar 9, 2021

The upstream issues is closed.

@DonJayamanne
Copy link
Contributor Author

Closing this as we've done what needs to be done, and we'll update the changes when there are new changes to propopsed API and workspace trust.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug upstream-vscode Blocked on upstream VS code
Projects
None yet
Development

No branches or pull requests

2 participants