You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
All of the above methods in the interface are only used in one place and one context.
Hence we should try to avoid adding these methods to a very generic interface,
Better to just expose the ContentManager and move all of the code into the Export or other layer rathe than keeping creation/deletion/reading of files in the IJupyterKernelSession class/interface.
Suggestions:
Expose the ContentManager of IJupyterSessionManager, this way we do not need anything IJupyterKernelSession.
After all, all of the above 4 methods on the session has nothing to do with the kernel session, but its about content management.
DonJayamanne
changed the title
Refactor Export on Web to remove unnecessary methods on IJupyterKernelSession
Export Notebook for Web: call JupyterLab#ContentManager directly to simplify JupyterKernelSessionJun 12, 2023
All of the above methods in the interface are only used in one place and one context.
Hence we should try to avoid adding these methods to a very generic interface,
Better to just expose the
ContentManager
and move all of the code into the Export or other layer rathe than keeping creation/deletion/reading of files in theIJupyterKernelSession
class/interface.Suggestions:
ContentManager
ofIJupyterSessionManager
, this way we do not need anythingIJupyterKernelSession
.After all, all of the above 4 methods on the session has nothing to do with the kernel session, but its about content management.
Also see #13578
The text was updated successfully, but these errors were encountered: