Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for File-> Revert File feature in Custom Editor #1323

Closed
DonJayamanne opened this issue Jun 16, 2020 · 2 comments
Closed

Add support for File-> Revert File feature in Custom Editor #1323

DonJayamanne opened this issue Jun 16, 2020 · 2 comments

Comments

@DonJayamanne
Copy link
Contributor

Currently this is't hook up.
Based on docs, we need to revert the Notebook to the originally saved state.

  • Today we seem to be attempting to revert it to the last hot exit state
  • We aren't modifying the existing model (we're loading a new model)

We'd need to modify the current model and re-send all the cells back up to the UI
Note sure how this impacts undo/redo.
Also not sure how widely this is used.

@DonJayamanne
Copy link
Contributor Author

DonJayamanne commented Jun 16, 2020

FYI - we need to implement the same thing for VSC Notebooks, might be easier there as we don't need to track undo/redo etc, we just need to re-build the VS Code Notebook document anew.

Yay, with VSC Notebooks, our API doesn't need to support this. VSC will just re-open the document.

Hence this feature is only required for Custom editor

@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-python Nov 13, 2020
@greazer
Copy link
Member

greazer commented Aug 2, 2021

Thanks for your feedback. This issue will likely be addressed once VS Code adds native support for editing notebooks. Please see microsoft/vscode#91987.

@greazer greazer closed this as completed Aug 2, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants