Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connecting to remote jupyter server issues #13015

Closed
Tracked by #12832
DonJayamanne opened this issue Mar 7, 2023 · 10 comments
Closed
Tracked by #12832

Connecting to remote jupyter server issues #13015

DonJayamanne opened this issue Mar 7, 2023 · 10 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug notebook-remote Applies to remote Jupyter Servers verified Verification succeeded

Comments

@DonJayamanne
Copy link
Contributor

DonJayamanne commented Mar 7, 2023

Scenario: Setup a password protected jupyter server

  1. non-https prompt at the bottom right
  • Connect to the server via the kernel picker
  • After entering the URI a prompt is displayed asking the user whether to allow connecting to non-https or not
    This prompt is far from the URI input, right now the user is focused on the input box and could easily miss the prompt
    Should this be modal or a button right next to the URI? Or should it be part of the quick pick itself.
  1. non-https prompt upon re-loading vscode
  • Re-load vscode
  • Open a notebook
  • A prompt will be displayed at the bottom right asking whether to allow non-http servers
    Why is this there, user woudl not have any idea
    There is no context indicating it is related to the jupyter server
    However why prompt again, when the user had already accepted this for this server once before, the server is still the same
  1. prompted to enter a password opening opening a notebook after reloading vsdoe
  • Re-load vscode
  • Open a notebook
  • User is prompted to enter a password (no idea why or what this password is for)
    User could end up entering their OS password or the like.
    Password should be saved in encrypted storage instead of prompting everytime
  1. poor error message in kernel picker
  • Re-load vscode
  • Open a notebook
  • Click no for https or do not enter a password (when promtped)
  • Go into the kernel picker, and now user does not know exactly why the kernels are not displayed
  1. no way to recover from non-https or no password
  • Re-load vscode
  • Open a notebook
  • Click no for https or do not enter a password (when promtped)
  • Go into the kernel picker, and there is an error mesage for the kernels of the remote server
  • How can the user recover from this, there are no messages/instructions for resolving this.
    We need a button that says Enable non-http reqyest Enter Password or Retry Connection, that would then prompt the user for the missing information (go though the same process that we go though when entering the URI)

We try to figure out whether its jupyter hub or not

I think it would be better to prompt the user to make the selection
I.e. have two options,

  • Enter Jupyter Server (Notebook/Lab)
  • Enter Jupyter Hub Uri

Or have a separate entry in the jupyter servers for Jupyter Hub

@DonJayamanne DonJayamanne added the bug Issue identified by VS Code Team member as probable bug label Mar 7, 2023
@DonJayamanne DonJayamanne self-assigned this Mar 7, 2023
@DonJayamanne DonJayamanne added notebook-remote Applies to remote Jupyter Servers notebook-kernel-remote labels Mar 7, 2023
@joyceerhl

This comment was marked as resolved.

@DonJayamanne

This comment was marked as resolved.

@bamurtaugh

This comment was marked as resolved.

@DonJayamanne

This comment was marked as off-topic.

@joyceerhl

This comment was marked as off-topic.

@DonJayamanne
Copy link
Contributor Author

DonJayamanne commented Mar 22, 2023

Oh, i could have sworn we removed that, thank will remove that, #13144

@bamurtaugh
Copy link
Member

bamurtaugh commented Apr 6, 2023

After observing users go through this flow in vscode.dev, I have a couple feedback points - let me know if they should be separate issues or tracked in this one:

  • Pasting anything for users in the server input field - they'll often assume it's correct, even if it's a bogus URL: Don't paste anything in Jupyter server input field #13285
  • When users enter vanilla vscode.dev without any remote Jupyter server, they're very confused. They assume Jupyter has generated and will provide them a remote server. Can we explore how to make this process clearer, like potentially guiding users to "Continue Working On" in the case switching dev environments is a better choice for them?
    image
  • It'd also be great to update the remote Jupyter wiki and Jupyter extension readme to mention the base vscode.dev scenario where a user doesn’t have (and may not want to generate) a remote Jupyter server, i.e. again guiding them to Continue Working On

@DonJayamanne
Copy link
Contributor Author

We have individual issues for each, and others have been resolved.
Closing this issue.

@andreamah andreamah added the verification-steps-needed Steps to verify are needed for verification label Sep 27, 2023
@andreamah
Copy link

Are there some verif steps for this?

@DonJayamanne
Copy link
Contributor Author

No,

We have individual issues for each

marking as verified

@DonJayamanne DonJayamanne added verified Verification succeeded and removed verification-steps-needed Steps to verify are needed for verification labels Sep 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug notebook-remote Applies to remote Jupyter Servers verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants