Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify local or remote Jupyter server for connections broken #1118

Closed
clayms opened this issue Nov 13, 2020 · 10 comments
Closed

Specify local or remote Jupyter server for connections broken #1118

clayms opened this issue Nov 13, 2020 · 10 comments

Comments

@clayms
Copy link

clayms commented Nov 13, 2020

Issue Type: Bug

Communicating the migration instructions after factoring out Jupyter extension from the Python extension has been ham-handed.
among others: #1057

It is not at all clear that to get to the pop-up selection menu to input a new server in the ctrl+shift+p menu, input Jupyter: Specify local or remote Jupyter server for connections.

If I select Jupyter: Specify local or remote Jupyter server for connections, even if its the same server it is already connected to, VS Code will force me to reload/restart VS Code. If I don't restart and select Jupyter: Specify local or remote Jupyter server for connections again, I get a VS Code ERROR:

Command 'Jupyter: Specify local or remote Jupyter server for connections' resulted in an error (command 'jupyter.selectjupyteruri' not found)

Also, how can I delete urls from the list of recently used servers+tokens? It is keeping a list of all of the Jupyter servers that have long since been shut down.

Is it possible to specify the server in the .code-workspace settings like I used to before the Jupyter extension was factored out of the Python extension? It was much more convenient to simply specify "python.dataScience.jupyterServerURI": "http://100.100.100.001:8888/?token=*******************" in the settings.

Why was the python.dataScience.jupyterServerURI setting not ported over to the Jupyter extension as jupyter.jupyterServerURI along with most of the other python.dataScience settings?

Extension version: 2020.11.358541065
VS Code version: Code 1.51.1 (e5a624b788d92b8d34d1392e4c4d9789406efe8f, 2020-11-10T23:34:32.027Z)
OS version: Windows_NT x64 10.0.18363

System Info
Item Value
CPUs Intel(R) Core(TM) i5-6300U CPU @ 2.40GHz (4 x 2496)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
opengl: enabled_on
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 15.88GB (1.95GB free)
Process Argv --crash-reporter-id f652528b-5678-4b12-9ca0-3de6b1e1135f
Screen Reader no
VM 0%
@clayms
Copy link
Author

clayms commented Nov 13, 2020

why can't I simply specify something similar to the following in my .code-workspace file ?

"settings":  {
    "jupyter.jupyterServerType": "remote"
    "jupyter.jupyteruri": "http://111.111.111.111:8888/?token=*************************************"

Where does the Jupyter extension save the remote jupyter server URI?

@clayms
Copy link
Author

clayms commented Nov 13, 2020

now I am getting

Unable to open 'Interactive - #1': Cannot read property 'createKey' of undefined.

and

Unable to write into workspace settings. Please open the workspace settings to correct errors/warnings in the file and try again.

@clayms
Copy link
Author

clayms commented Nov 13, 2020

well ... here is one ....

"jupyter.command.jupyter.clearSavedJupyterUris.title": "Clear Jupyter server list",

@clayms
Copy link
Author

clayms commented Nov 13, 2020

How can I set serverUriStorage.Uri directly?

// Special case. URI is no longer supported. Move it to storage
if (k === 'python.dataScience.jupyterServerURI') {
this.serverUriStorage.setUri(val).ignoreErrors();

@rchiodo
Copy link
Contributor

rchiodo commented Nov 13, 2020

Sorry but setting the server URI directly is not supported. You have to use the command. It's stored in encrypted storage as this value may contain a token to a Jupyter server that you wouldn't want to expose on your file system.

@rchiodo
Copy link
Contributor

rchiodo commented Nov 14, 2020

python.dataScience.jupyterServerURI setting not ported over to the Jupyter extension as jupyter.jupyterServerURI

This should have happened automatically. It doesn't get ported to the same setting as it doesn't exist though. What should have happened is that it was encrypted and stored internally.

@rchiodo
Copy link
Contributor

rchiodo commented Nov 14, 2020

Communicating the migration instructions after factoring out Jupyter extension from the Python extension has been ham-handed.

Was there something else you're having trouble with besides your remote setting?

@rchiodo
Copy link
Contributor

rchiodo commented Nov 14, 2020

We're also planning on revamping the remote support. Something more akin to this is coming:
#1366

@smackesey
Copy link

Agree that this is very confusing (change in behavior of python.dataScience.jupyterServerURI), I could not figure out why my environment suddenly changed. There is no explanation of changes due to migration (that I could find) in the docs. Also there is no explanation of what @rchiodo mentions above about the server URI being kept in encrypted storage. Is there any way to view this setting?

@rchiodo
Copy link
Contributor

rchiodo commented Nov 17, 2020

Is there any way to view this setting?

The only way to view the setting is to bring up the 'Specify local or remote Jupyter server for connections' picker. It will show the current value at the top:

image

We should probably have a 'what's changed' in the release notes that describes what's changed.

I can do a brief summary here:

As far as I remember that should be the sum total of the differences. I'll add a bug to put this in our release notes (and or documentation)

@rchiodo rchiodo closed this as completed Nov 17, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants