Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement logging #55

Closed
roblourens opened this issue Oct 25, 2019 · 2 comments
Closed

Implement logging #55

roblourens opened this issue Oct 25, 2019 · 2 comments
Assignees
@connor4312
Labels
feature-request Request for new features or functionality
Milestone
Self-Host

Comments

@roblourens
Copy link
Member

We need logging similar to what v1/v2 do, for our own debugging and for users who file issues. Including CDP/DAP traffic and useful internal tracing info.
@roblourens roblourens mentioned this issue Oct 25, 2019
Closed
8 tasks
@connor4312
Copy link
Member

I'll take this next--getting logging going would make debugging in general a lot easier, particular as we go into more intricate work with sourcemaps etc...

@connor4312 connor4312 self-assigned this Nov 1, 2019
@connor4312 connor4312 added this to the v0.0.0 milestone Nov 4, 2019
@connor4312 connor4312 added the feature-request Request for new features or functionality label Nov 4, 2019
@connor4312
Copy link
Member

connor4312 commented Nov 5, 2019 •
edited
Loading

Added in #67. I reused the previous "trace" option, but the generated logs are now JSON. I created a tool to view these logs here: https://github.com/microsoft/vscode-pwa-analyzer

@connor4312 connor4312 mentioned this issue Nov 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@connor4312 connor4312

Labels
feature-request Request for new features or functionality
Projects
None yet
Milestone
Self-Host
Development

No branches or pull requests
2 participants
@roblourens @connor4312