Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XSL self-closing tags not expanding properly #37

Closed
rzhao271 opened this issue Oct 12, 2020 · 4 comments
Closed

XSL self-closing tags not expanding properly #37

rzhao271 opened this issue Oct 12, 2020 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug duplicate

Comments

@rzhao271
Copy link
Contributor

As an example, for XSL files, cp should expand to <xsl:copy select="|" />, but right now it expands to <xsl:copy select="|">|</xsl:copy>.
This issue occurs for two reasons:

  • In the snippets within expand-full.js, we have the mapping "cp": "xsl:copy[select]", without the / at the end. Therefore, the expander interprets the tag as one with content in between.
  • Even if / is added to the end, the XSL content is interpreted as HTML and expands to <xsl:copy select="|">, which is not a valid self-closing tag within XSL.
@rzhao271 rzhao271 added the bug Issue identified by VS Code Team member as probable bug label Oct 12, 2020
@rzhao271 rzhao271 self-assigned this Oct 12, 2020
@rzhao271
Copy link
Contributor Author

rzhao271 commented Nov 6, 2020

Note to self: this issue should be fixed after migrating to the latest Emmet

@rzhao271 rzhao271 added this to the January 2021 milestone Jan 25, 2021
@rebornix rebornix added the verified Verification succeeded label Jan 29, 2021
@rebornix
Copy link
Member

It seems that in latest Insiders it still expands to <xsl:copy select=""></xsl:copy>

@rebornix rebornix removed the verified Verification succeeded label Jan 29, 2021
@rebornix rebornix reopened this Jan 29, 2021
@rzhao271 rzhao271 removed this from the January 2021 milestone Jan 29, 2021
@rzhao271
Copy link
Contributor Author

True. I'll currently leave that part as a wontfix, but I'll keep the issue open now that I realized:

  • For cp/, Emmet doesn't automatically suggest <xsl:copy select="" /> 🩸
  • When one expands cp/ via the 'Expand Abbreviation' command it becomes <xsl:copy select=""/> with no space before the /, though this could just be preferences more than anything.

@rzhao271
Copy link
Contributor Author

rzhao271 commented Apr 2, 2021

Duplicate of microsoft/vscode#120203

@rzhao271 rzhao271 marked this as a duplicate of microsoft/vscode#120203 Apr 2, 2021
@rzhao271 rzhao271 closed this as completed Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug duplicate
Projects
None yet
Development

No branches or pull requests

2 participants