Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Unity Package Netcode for Entities crashes the LanguageServerHost #333

Closed
976047167 opened this issue Aug 5, 2023 · 10 comments
Closed
Assignees
Labels
area-roslyn area-unity Unity support bug Something isn't working triaged The issue has been triaged
Milestone

Comments

@976047167
Copy link

Describe the Issue

image
My unity project requires the "net code for entities" package. When I import it, the vscdoe spell checking is not working. And it starts reporting errors

Steps To Reproduce

1、create a unity project
2、choose "window/package manager"
3、import "Netcode for Entities"
4、run vscode

Expected Behavior

No response

Environment Information

-VS code:
Version: 1.81.0 (user setup)
Commit: 6445d93c81ebe42c4cbd7a60712e0b17d9463e97
Date: 2023-08-02T12:37:13.485Z
Electron: 22.3.18
ElectronBuildId: 22689846
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: 10.8.168.25-electron.0
OS: Windows_NT x64 10.0.25217

  • Unity: 2022.3.4f1
    Netcode for Entities: 1.0.12
@976047167 976047167 added the bug Something isn't working label Aug 5, 2023
@jbevain
Copy link
Member

jbevain commented Aug 5, 2023

Hi @976047167,

Thanks a lot for reporting this. I can reproduce the issue. We'll look into it and get back to you.

@jbevain jbevain added area-project Project load, Solution Explorer area-unity Unity support and removed area-project-cps labels Aug 5, 2023
@jbevain jbevain changed the title [BUG]Connect to LanguageServerHost error [BUG] Unity Package Netcode for Entities crashes the LanguageServerHost Aug 5, 2023
@arunchndr
Copy link
Member

@jbevain we can work together on this. cc: @dibarbet

@kvenkatrajan kvenkatrajan added area-roslyn and removed area-project Project load, Solution Explorer labels Aug 21, 2023
@arunchndr
Copy link
Member

Keeping on dotnettools for now since we are not sure if this could be a RPC issue yet. @beccamc feel free to move when ready.

@arunchndr arunchndr added this to the Unity GA milestone Aug 22, 2023
@arunchndr arunchndr added the triaged The issue has been triaged label Aug 22, 2023
@SoprachevAK
Copy link

Do you have any progress on fixing this issue? Can you share the estimated finish time?

@976047167
Copy link
Author

976047167 commented Aug 30, 2023

Do you have any progress on fixing this issue? Can you share the estimated finish time?

Choose JetBrains Rider instead of VSC

@d-bucur
Copy link

d-bucur commented Sep 2, 2023

Same issue on Ubuntu 22.04, just no errors in the C# logs. On a project without Entities it does work.

@jbevain
Copy link
Member

jbevain commented Sep 5, 2023

Good news folks, our LSP team has identified the issue and has a fix that is being reviewed. Hopefully the fix lands soon, we'll close the issue when it does.

@SoprachevAK
Copy link

Roslyn pipe server stream was merged and fixing this error doesn’t block anything. What are the next steps?

@jbevain
Copy link
Member

jbevain commented Sep 20, 2023

@SoprachevAK the fix has been merged but it hasn't shipped yet.

@dibarbet
Copy link
Member

dibarbet commented Sep 22, 2023

We just released version 2.3.27 of the C# extension (changelog) which contains the fix.

If you're still having problems after upgrading, please open a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-roslyn area-unity Unity support bug Something isn't working triaged The issue has been triaged
Projects
None yet
Development

No branches or pull requests

8 participants